Forward porting Gloo service lookup by labels to 1.19.x #10669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issues linked to changelog: |
|
/kick |
andy-fong
approved these changes
Feb 27, 2025
|
Visit the preview URL for this PR (updated for commit 1033c97): https://gloo-edge--pr10669-rolds-forwardport-gl-8edeuqjz.web.app (expires Tue, 11 Mar 2025 16:33:53 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 77c2b86e287749579b7ff9cadb81e099042ef677 |
sam-heilbron
approved these changes
Mar 4, 2025
| @@ -383,8 +388,8 @@ func awsStsClusterAssertion(testInstallation *e2e.TestInstallation) func(ctx con | |||
| g.Expect(socketAddr.GetAddress()).To(gomega.Equal(expectedStsUri)) | |||
| }). | |||
| WithContext(ctx). | |||
| WithTimeout(time.Second * 10). | |||
| WithPolling(time.Millisecond * 200). | |||
| WithTimeout(time.Second * 30). | |||
There was a problem hiding this comment.
I'm good with this change. I'm always a little nervous when we have timeouts that take 30 seconds (or some time frame beyond what I would expect for a change to propagate in a small environment) since those can be a signal of some other issue going on that we're masking.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Forward porting the Gloo service discovery changes made to 1.17.x. Added namespace argument to service lookup to make it easier to test.
Checklist: