Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GRPC Passthrough documentation and test server update #10676

Merged
merged 6 commits into from
Mar 3, 2025

Conversation

sheidkamp
Copy link

@sheidkamp sheidkamp commented Mar 3, 2025

Description

Update Auth passthrough docs:

  • Update GRPC/HTTP passthrough docs to allow both examples to be run at the same time
  • Call out GRPC body passthrough specifically

Update the GRPC/HTTP passthrough example servers to log the full requests received if the REQUEST_LOGGING env var is set and update to current version of go/dependencies

Update GRPC passthrough documentation to describe use of settings.extauth.requestBody

Code changes

Update the GRPC/HTTP passthrough example servers to log the full requests received if the REQUEST_LOGGING env var is set

API Changes

Update GRPC passthrough documentation to describe use of settings.extauth.requestBody

Docs changes

GRPC/HTTP passthrough examples updaetd

Context

Users asked for GRPC body passthrough, and an RFE was passed through the engineering team, but the functionality already existed. This functionality relies on settings.extauth.requestBody being set, and that was not documented in appropriate place.

Testing steps

validated by running through both HTTP and GRPC passthrough examples in the same cluster

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@solo-changelog-bot
Copy link

Issues linked to changelog:
https://github.com/solo-io/solo-projects/issues/7893

@sheidkamp
Copy link
Author

Marking as "work in progress" to guarantee docs team review

Copy link

github-actions bot commented Mar 3, 2025

Visit the preview URL for this PR (updated for commit 0934e87):

https://gloo-edge--pr10676-passthrough-qol-zr0xigu8.web.app

(expires Mon, 10 Mar 2025 15:14:03 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 77c2b86e287749579b7ff9cadb81e099042ef677

@soloio-bulldozer soloio-bulldozer bot merged commit 98c7bdd into main Mar 3, 2025
20 checks passed
@soloio-bulldozer soloio-bulldozer bot deleted the passthrough-qol branch March 3, 2025 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants