Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup uniquehash files #10680

Merged
merged 3 commits into from
Mar 5, 2025
Merged

Cleanup uniquehash files #10680

merged 3 commits into from
Mar 5, 2025

Conversation

ryanrolds
Copy link

@ryanrolds ryanrolds commented Mar 4, 2025

Description

The *.pb.uniquehash.go shouldn't have committed. They were left from a failed command.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@ryanrolds ryanrolds marked this pull request as ready for review March 4, 2025 21:44
Copy link

@sam-heilbron sam-heilbron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that CI did pass successfully, is there a gap we have identified in our codegen job that allows code to merge that should not?

@ryanrolds
Copy link
Author

I'm pretty sure these were intermediate files that I accidentally committed thinking they were updated .pb.go files. It may be useful to add them to the .gitignore.

@soloio-bulldozer soloio-bulldozer bot merged commit 35b7ed1 into v1.15.x Mar 5, 2025
12 checks passed
@soloio-bulldozer soloio-bulldozer bot deleted the rolds/cleanup_uniquehash branch March 5, 2025 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants