Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.17.x/grpc access log filter state #10692

Merged
merged 2 commits into from
Mar 10, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions changelog/v1.17.27/grpc-access-log-filter-states.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
changelog:
- type: FIX
issueLink: https://github.com/solo-io/solo-projects/issues/7923
resolvesIssue: false
description: >-
Add support for setting filter state from the grpc access log with the
gatewayProxies.gatewayProxy.gatewaySettings.accessLoggingService.accessLog.grpcService.filterStateObjectsToLog helm value

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 8 additions & 0 deletions install/helm/gloo/crds/gateway.solo.io_v1_Gateway.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5919,6 +5919,10 @@ spec:
items:
type: string
type: array
filterStateObjectsToLog:
items:
type: string
type: array
logName:
type: string
staticClusterName:
Expand Down Expand Up @@ -6094,6 +6098,10 @@ spec:
items:
type: string
type: array
filterStateObjectsToLog:
items:
type: string
type: array
logName:
type: string
staticClusterName:
Expand Down
8 changes: 8 additions & 0 deletions install/helm/gloo/crds/gateway.solo.io_v1_ListenerOption.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -178,6 +178,10 @@ spec:
items:
type: string
type: array
filterStateObjectsToLog:
items:
type: string
type: array
logName:
type: string
staticClusterName:
Expand Down Expand Up @@ -353,6 +357,10 @@ spec:
items:
type: string
type: array
filterStateObjectsToLog:
items:
type: string
type: array
logName:
type: string
staticClusterName:
Expand Down
8 changes: 8 additions & 0 deletions install/helm/gloo/crds/gloo.solo.io_v1_Proxy.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -225,6 +225,10 @@ spec:
items:
type: string
type: array
filterStateObjectsToLog:
items:
type: string
type: array
logName:
type: string
staticClusterName:
Expand Down Expand Up @@ -400,6 +404,10 @@ spec:
items:
type: string
type: array
filterStateObjectsToLog:
items:
type: string
type: array
logName:
type: string
staticClusterName:
Expand Down
1 change: 1 addition & 0 deletions projects/accesslogger/pkg/runner/run.go
Original file line number Diff line number Diff line change
Expand Up @@ -154,6 +154,7 @@ func Run() {
zap.Any("start_time", v.GetCommonProperties().GetStartTime()),
zap.Any("downstream_resp_time", downstreamRespTimeNs),
zap.Any("upstream_resp_time", upstreamRespTimeNs),
zap.Any("filter_state_objects", v.GetCommonProperties().GetFilterStateObjects()),
).Info("received http request")
}
case *pb.StreamAccessLogsMessage_TcpLogs:
Expand Down
4 changes: 4 additions & 0 deletions projects/gloo/api/v1/options/als/als.proto
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,10 @@ message GrpcService {
repeated string additional_response_headers_to_log = 5;

repeated string additional_response_trailers_to_log = 6;

// Additional filter state objects to log in filter_state_objects. Logger will call FilterState::Object::serializeAsProto to serialize the filter state object.
// See https://www.envoyproxy.io/docs/envoy/latest/api-v3/extensions/access_loggers/grpc/v3/als.proto#extensions-access-loggers-grpc-v3-commongrpcaccesslogconfig
repeated string filter_state_objects_to_log = 7;
}

message AccessLogFilter {
Expand Down
9 changes: 9 additions & 0 deletions projects/gloo/pkg/api/v1/options/als/als.pb.clone.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

11 changes: 11 additions & 0 deletions projects/gloo/pkg/api/v1/options/als/als.pb.equal.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading