Skip to content

Commit

Permalink
add changelog and remove test focus
Browse files Browse the repository at this point in the history
  • Loading branch information
saiskee committed Apr 8, 2024
1 parent 4a80b66 commit 874e6df
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 4 deletions.
8 changes: 5 additions & 3 deletions changelog/v0.36.6/sets-v2-iter.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
changelog:
- type: NON_USER_FACING
issueLink:
- type: BREAKING_CHANGE
issueLink: https://github.com/solo-io/skv2/issues/543
description: >
""
v2 sets have been refactored to use a slice as the backing data structure, allowing for faster GC time of entire sets,
and more efficient iteration over the set. A few methods have been removed, namely `List` and `UnsortedList`, both which have been
replaced with a more accurate name: "FilterOutAndCreateList". In addition, a `Filter` and `Iter` method have been added to v2 sets.
skipCI: "false"
2 changes: 1 addition & 1 deletion contrib/tests/set_v2_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import (
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
)

var _ = FDescribe("PaintSetV2", func() {
var _ = Describe("PaintSetV2", func() {
var (
setA, setB sets_v2.ResourceSet[*v1.Paint]
paintA, paintBCluster2, paintC *v1.Paint
Expand Down

0 comments on commit 874e6df

Please sign in to comment.