Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign #41

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Redesign #41

wants to merge 13 commits into from

Conversation

tkaessmann
Copy link

No description provided.

@epugh
Copy link
Contributor

epugh commented Dec 22, 2020

This looks great! I was able to get it up and running easily! I wanted to provide some feedback, is here the best place?

  • When you hihglight over a component, I expect to click anywhere in the highlight to go to the detail page, not just on "View Details" button...
  • Is having an explicit navigation BACK from the detail page worth adding? Though you do lose your filter if you picked one..
  • Thoughts about supporting a logo/icon for a plugin? For example, SolrSWAN has a icon.. (https://github.com/o19s/SolrSwan), maybe if it's in the manifest it could be included? We have a image on the detail page, can it be swapped for the logo or a screenshot? Screenshots also could be good for some components...
  • I really like having a detail page, makes it much less cramped feeling!
  • What happens if we double the number of categories from the six we have to say 12? Will the selector wrap nicely? I can imagine many more categories.
  • Is there any way to filter based on tags? For example, show me all by license? Or maybe if we have versions of Solr, you could see the by version they support? (Assumeing we had that info!)
  • Right now the Call to Action for adding your plugin is down at the bottom. Could we also maybe add it to the left nav? Solr.cool becomes more useful the more we have added to it! So we need to encourage that network effect.

All in all, this is really really nicely done! If you want any copy-editing of the text, let me know.

@MarcusSorealheis
Copy link

Awesome work!

@epugh
Copy link
Contributor

epugh commented Jan 21, 2021

any thoughts on how to move this forward?

@tkaessmann
Copy link
Author

tkaessmann commented Jan 21, 2021

Sorry. Only need more time ;)
But if anyone is interested, feel free to contribute.

For me it would be also ok to merge this PR as it is and to move the suggestions to an issue...

@tboeghk
Copy link
Member

tboeghk commented Jan 22, 2021

Holy moly, just got back to this project again. I'll try to merge the redesign and then move forwards feature wise in the master branch.

@tboeghk tboeghk mentioned this pull request Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants