[BG-132]: 워크스페이스 생성 API 기능 구현 (3h / 5h) #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODO: 실제 유저의 인증 정보를 추후에 넣어줘야함
Dltmd202
reviewed
Jun 25, 2024
| import org.springframework.web.bind.annotation.RequestBody | ||
| import org.springframework.web.bind.annotation.RestController | ||
|
|
||
| @RestController("/api/v1") |
There was a problem hiding this comment.
내 기억에 RequestMapping으로 들어갔던 것 같은뎅!
확인부탁행!
Comment on lines
3
to
9
| enum class Role( | ||
| var key: String, | ||
| var value: String, | ||
| ) { | ||
| MEMBER("ROLE_MEMBER", "Member"), | ||
| LEADER("ROLE_LEADER", "Leader"), | ||
| } |
There was a problem hiding this comment.
나중에 유저쪽 Role이랑 워크스페이스쪽 Role이랑 같이 등장할 일이 있을텐데 enum 이름이 같으면 충돌이 생길 것 같은데
어때??
Dltmd202
approved these changes
Jun 25, 2024
Comment on lines
+3
to
+9
| enum class WorkspaceRole( | ||
| var key: String, | ||
| var value: String, | ||
| ) { | ||
| MEMBER("ROLE_MEMBER", "Member"), | ||
| LEADER("ROLE_LEADER", "Leader"), | ||
| } |
GGHDMS
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
워크스페이스 생성 기능 구현
How
단순하게 현재는 생성만 구현하였음
그래서 예상보다 시간이 덜 걸렸다
Result
Prize
서비스 로직에서 단순히 객체를 생성해주고 있는데
이게 맞을지 생각해 봐야 될듯...
Link
BG-132