Skip to content
This repository was archived by the owner on Sep 18, 2020. It is now read-only.

Added support for relative paths inside proxies in generated index.yaml - #128

Open
tmckeag wants to merge 3 commits into
sonatype-nexus-community:masterfrom
tmckeag:master
Open

Added support for relative paths inside proxies in generated index.yaml#128
tmckeag wants to merge 3 commits into
sonatype-nexus-community:masterfrom
tmckeag:master

Conversation

@tmckeag

@tmckeag tmckeag commented Apr 30, 2020

Copy link
Copy Markdown

This pull request makes the following changes:

  • Makes the relative-URL writing in the proxy index generator (IndexAbsoluteUrlRewriter) aware of the URL of the remote repository.
  • Changes URL rewrite to add appropriate consideration for relative paths inside the proxied repository.
  • Adds a test case in the relative .yaml test resource to ensure behavior is correct.

It relates to the following issue #s:

@sonatypecla

sonatypecla Bot commented Apr 30, 2020

Copy link
Copy Markdown

Thanks for the contribution! Unfortunately we can't verify if the committer(s), 212486039 tory.mckeag@ge.com, signed the CLA because they have not associated their commits with their GitHub user. Please follow these instructions to associate your commits with your GitHub user. Then sign the Sonatype Contributor License Agreement and this Pull Request will be revalidated.

@sonatypecla

sonatypecla Bot commented Apr 30, 2020

Copy link
Copy Markdown

Thanks for the contribution! Before we can merge this, we need @tmckeag to sign the Sonatype Contributor License Agreement.

@mlukaretkyi

mlukaretkyi commented Aug 4, 2020

Copy link
Copy Markdown
Contributor

@tmckeag
Hi, thanks for your PR. Could you take a look at this issue?
#94
As far as I understand you try to fix this issue, but I think we need to implement this in a different way.
I think you need to take a look at HelmProxyFacetImpl.getCachedContent. My guess, you can rewrite URLs in this method

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants