Skip to content
This repository was archived by the owner on Sep 18, 2020. It is now read-only.

Add support to download index.yaml in subfolder path - #21

Open
ghost wants to merge 1 commit into
sonatype-nexus-community:masterfrom
autonomic-ai:custom_helm_plugin
Open

Add support to download index.yaml in subfolder path#21
ghost wants to merge 1 commit into
sonatype-nexus-community:masterfrom
autonomic-ai:custom_helm_plugin

Conversation

@ghost

@ghost ghost commented Oct 29, 2018

Copy link
Copy Markdown

This change is to support repo that is located under subfolder.

This pull request makes the following changes:

  • This PR make sure when modifying absolute path in index.yaml, it will consider the whole path (including subfolder) that user input in remote storage.

It relates to the following issue #s:

@sonatypecla

sonatypecla Bot commented Oct 29, 2018

Copy link
Copy Markdown

Thanks for the contribution! Before we can merge this, we need @au-hao @au-wendy to sign the Sonatype Contributor License Agreement.

@sonatypecla

sonatypecla Bot commented Oct 29, 2018

Copy link
Copy Markdown

Thanks for the contribution! Before we can merge this, we need @au-hao to sign the Sonatype Contributor License Agreement.

@ghost ghost changed the title Custom helm plugin Add support to download index.yaml in subfolder path Oct 29, 2018
@DarthHater

Copy link
Copy Markdown
Member

Thanks for sending this over! I'll try and take a look at it today or early next week!

@au-hao

au-hao commented Nov 2, 2018

Copy link
Copy Markdown

@DarthHater Thanks. And one thing this fix doesn't cover is that chart and index.yaml are in two places which I think you mentioned in one ticket before.

@DarthHater

Copy link
Copy Markdown
Member

Hah yeah, the wild world of people doing wacky things :)

@ghost

ghost commented Nov 19, 2018

Copy link
Copy Markdown
Author

Hi @DarthHater any update on merging the PR?

.get("remoteUrl");

return new StreamCopier<>(outputStream -> updateUrls(index.get(), outputStream),
return new StreamCopier<>(outputStream -> updateUrls(index.get(), outputStream, remoteUrl),

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't this return a URL to the remote to the client therefore causing the client to circumvent NXRM?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sergeyonofreychuck can your team double check this?

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it on a small environment without having issues. Can you please merge it?

@mlukaretkyi

Copy link
Copy Markdown
Contributor

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants