call_oss_index doesn't run without token

[sierrajohnson]

Describe the bug
Any time you run a function that relies on call_oss_index without a token, it errors.

To Reproduce
Looks like this is currently failing in the tests for this package. For example, run audit_description() with no arguments in a repo with no OSSINDEX secrets.

Expected behavior
From reading the documentation, I would expect this to run, or if it fails it would be after the check_status_code. If it's not possible to run without tokens anymore, I'd recommend updating the readme and other documentation.

Desktop (please complete the following information):

• OS: windows
• R Version: 4.5.0
• oysteR Version 0.1.4

Additional context
Experimenting with the code a little, I think a couple changes would be needed.

1. Something like this so that token doesn't get reassigned to NA.

get_token = function(token, verbose = TRUE) {
  if (is.null(token)) {
    user = Sys.getenv("OSSINDEX_USER", NA)
    tokencode = Sys.getenv("OSSINDEX_TOKEN", NA)
    if (!is.na(user) && !is.na(tokencode)) {
      token = list(user = user, token = tokencode)
    }

2. I don't quite understand how the code should work without a token, but something would also need to change in the httr calls in call_oss_index

[csgillespie]

@bhamail Is the API still accessible anonymously?

@sierrajohnson Once I get the answer from @bhamail I'll update to clarify.

[PatrickRWright]

Since I think I'm running into the same thing I'll just ping this here too. I was just starting to look at oysteR and ran the code from the README.

> oysteR::audit_installed_r_pkgs()
ℹ Calling installed.packages(), this may take time
ℹ Using cached results for 0 packages

── Calling sonatype API: https://www.sonatype.com/ ──

→ Using Sonatype tokens
Error in token$user : $ operator is invalid for atomic vectors

OS: Ubuntu 22.04.5 LTS
R Version: 4.4.1
oysteR Version 0.1.4

Update after creating an account at https://ossindex.sonatype.org/ and placing the token into the call, I get the same error.

e.g. I'm not showing the token for obvious reasons. Just showing the scheme so it's clear how I specified token.

oysteR::audit_installed_r_pkgs(token = "XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX")

Looks to me like this is where it goes "south" for me:

oysteR/R/call_os_index.R

Line 112 in 7b29b3f

authenticate = httr::authenticate(token$user, token$token, type = "basic")

Looking at that more closely it seems like token needs to be specified as a named list. e.g.
token <- list(user = "peter.parker@superman.com", token = "XXXXXXXXXXXXXXXXXXXXXXXXX")
It would be helpful if that was explicitly pointed out on the help pages wherever token can be specified as an input parameter.

Should I track the documentation request as a separate issue?