-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Fix slave on reinstall python wheel #24727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
9e7cdb5 to
17692aa
Compare
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes an issue where Python wheels are not reinstalled during the build process if they're already installed in the slave container. The fix adds the --force-reinstall flag to the pip install command to ensure wheels are always reinstalled for the $(PYTHON_WHEELS_PATH)/%-install target.
Key changes:
- Added
--force-reinstallflag to pip install command in the standard build path
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Co-authored-by: Copilot <[email protected]>
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
for sonic-py-common (not available in pypi)
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Why I did it
If one python wheel is already installed inside slave container, it will not install again. Below is a sample log:
However, we expect to reinstall the python wheel for target
$(PYTHON_WHEELS_PATH)/%-installWork item tracking
How I did it
Update slave.mk to enasure force install the python wheel.
How to verify it
After this change, local build will successfully force install the python wheel. See new logs:
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)