Refactor ledd daemon & fix high CPU usage due to unexpected socket close #548
+59
−41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Staphylo could you please help review? |
|
@assrinivasan @vvolam please review |
|
@prgeor nit: spelling issue in PR description.
Also, could you fix the build failure? |
|
|
||
| if state != swsscommon.Select.OBJECT: | ||
| self.log_warning("sel.select() did not return swsscommon.Select.OBJECT - May be socket closed???") | ||
| return -1 ## Fail here so that the daemon can be restarted |
There was a problem hiding this comment.
Consider return code = (128+non-zero-code) per all other daemons code.
There was a problem hiding this comment.
@assrinivasan do you know the reason for 128+ ?
There was a problem hiding this comment.
My understanding is that we use 128+[non-zero code] so that supervisor can restart the daemon. Since your comment in line 118 indicates that the daemon would need to be restarted, I suggested this change.
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
prgeor
changed the title
vvolam
reviewed
Feb 18, 2025
| if fvp: | ||
| # TODO: Once these flag entries have been removed from the DB, | ||
| # we can remove this check | ||
| if key in ["PortConfigDone", "PortInitDone"]: | ||
| return 3 | ||
| return |
There was a problem hiding this comment.
Are we ignoring bad fvp or key not present case now?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…close
Description
[ledd] Refactor ledd daemon and fix high CPU usage due to unexpected redis DB socket close
Motivation and Context
For unkown reason if redis closes the socket, then ledd daemon is continuously busy waiting for socket event and failing all the time. This is resulting in high CPI
How Has This Been Tested?
Close the socket abruptly and see ledd daemon is respawned so that new socket connection is established to redis DB without causing high CPU
Additional Information (Optional)