Credo AEC 400G firmware v4.1 needs to set low power mode when change to DPDeinit state #587
+107
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to DPDeinit state Description Credo AEC 400G needs to set low power mode when changing to DPDeinit state on firmware v4.1. After sonic-net#254 is merged, low power mode will not be set when changing to DPDeinit state. Motivation and Context This patch adds the code to set low power mode only when changing to DPDeinit state when the transceiver's vendor is 'Credo' and 'host_assign' is '1'(Which means the application mode only has 1 logical port on the transceiver). With this patch, the Credo AEC 400G can work correctly.
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@CharlieChenEC Please fix the coverage check |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…it_set_power_expired()' in test_xcvrd.py to enhance the test code coverage.
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
prgeor
reviewed
Feb 14, 2025
| @@ -1144,6 +1144,31 @@ def wait_for_port_config_done(self, namespace): | |||
| if key in ["PortConfigDone", "PortInitDone"]: | |||
| break | |||
|
|
|||
| def need_lp_mode_for_dpdeinit(self, api, appl): | |||
There was a problem hiding this comment.
@CharlieChenEC I don't think we can keep add vendor specific checks in a code that is generic and expects all modules to follow CMIS spec
prgeor
requested changes
Feb 14, 2025
There was a problem hiding this comment.
@CharlieChenEC please get the module updated to the firmware that is fully CMIS compliant. A module should honor low power mode at any time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Credo AEC 400G firmware v4.1 needs to set low power mode when change to DPDeinit state
Description
Credo AEC 400G needs to set low power mode when changing to DPDeinit state on firmware v4.1. After #254 is merged, low power mode will not be set when changing to DPDeinit state.
Motivation and Context
This patch adds the code to set low power mode only when changing to DPDeinit state when the transceiver's vendor is 'Credo' and 'host_assign' is '1'(Which means the application mode only has 1 logical port on the transceiver). With this patch, the Credo AEC 400G can work correctly.
How Has This Been Tested?
Insert AEC 400G on AS9716 and verify the cable is link up.