-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix code coverage and ASAN not being enabled #1338
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a breakage from sonic-net#1194 where code coverage and ASAN were not enabled, due to DEB_CONFIGURE_EXTRA_FLAGS no longer being used in dh_auto_configure. Signed-off-by: Saikrishna Arcot <[email protected]>
kcudnik
approved these changes
Jan 12, 2024
mssonicbld
pushed a commit
to mssonicbld/sonic-sairedis
that referenced
this pull request
Feb 2, 2024
This fixes a breakage from sonic-net#1194 where code coverage and ASAN were not enabled, due to DEB_CONFIGURE_EXTRA_FLAGS no longer being used in dh_auto_configure. Signed-off-by: Saikrishna Arcot <[email protected]>
Cherry-pick PR to 202311: #1348 |
@saiarcot895 cherry pick PR didn't pass PR checker. Please check!!! |
4 similar comments
@saiarcot895 cherry pick PR didn't pass PR checker. Please check!!! |
@saiarcot895 cherry pick PR didn't pass PR checker. Please check!!! |
@saiarcot895 cherry pick PR didn't pass PR checker. Please check!!! |
@saiarcot895 cherry pick PR didn't pass PR checker. Please check!!! |
mssonicbld
pushed a commit
that referenced
this pull request
Feb 10, 2024
This fixes a breakage from #1194 where code coverage and ASAN were not enabled, due to DEB_CONFIGURE_EXTRA_FLAGS no longer being used in dh_auto_configure. Signed-off-by: Saikrishna Arcot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a breakage from #1194 where code coverage and ASAN were not enabled, due to DEB_CONFIGURE_EXTRA_FLAGS no longer being used in dh_auto_configure.