-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing the sairedis build issue caused at https://github.com/sonic-ne… #1526
base: master
Are you sure you want to change the base?
Fixing the sairedis build issue caused at https://github.com/sonic-ne… #1526
Conversation
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
4f18dee
to
8a5e802
Compare
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
8a5e802
to
5785852
Compare
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
why not revert previous change ? |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
6a5c285
to
2e17f96
Compare
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
2e17f96
to
52fa1f5
Compare
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
I have removed the MOCK test which caused the error. |
you als ohave this:
since you are downgrading SAI from master to 15.4 that prefix entry don't exists, and it will pull cascade removal of apis in source code because of non existient definitions and types |
52fa1f5
to
310f51f
Compare
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
@kcudnik : I have removed the issue causing Mock method and restarted the build at sonic-net/sonic-buildimage#21685 . Once it is completed successfully , we should be able to go ahead with the merge for this PR. |
you removed just unittests here, how come this was passing on sairedis repo and not on buildimage ? |
I have removed the test which caused the failure. it fixed the build "Azure.sonic-buildimage (BuildVS vs)". But there are other failures at sonic-buildimage repo, which i am not able to link with my changes. |
310f51f
to
86bfba7
Compare
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
…21614 , Reverting the testcase
86bfba7
to
b527e08
Compare
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
@kcudnik Could you pls merge this? |
Why did i do this change ?
To fix the Build break mentioned at sonic-net/sonic-buildimage#21614