Use switch object to detect counter capability in flex counter #1540
+10
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
kcudnik
reviewed
Feb 21, 2025
syncd/FlexCounter.cpp
Outdated
| @@ -479,6 +479,9 @@ class CounterContext : public BaseCounterContext | |||
| { | |||
| std::map<std::string, uint32_t> m_counterChunkSizeMapFromPrefix; | |||
|
|
|||
| protected: | |||
| sai_object_id_t m_switchId; | |||
There was a problem hiding this comment.
this dont need to be a member, move it to function locally, since you are using this in 1 place
There was a problem hiding this comment.
but I do not want to fetch it every time it is called since the switch id hasn't changed
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Stephen Sun <[email protected]>
Signed-off-by: Stephen Sun <[email protected]>
stephenxs
force-pushed
the
fix-query-stat
branch
from
251efe6 to
929ee1d
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use switch object to detect counter capability in flex counter. This is to fix the follow error message on VS platform
This was a day 1 issue but is exposed recently.