Skip to content

vpp: fix bogus errors #1642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

vpp: fix bogus errors #1642

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
daa4fb0
Fix vpp error messages logged incorrectly
yue-fred-gao Aug 13, 2025
9cd5852
Merge remote-tracking branch 'origin/master' into bogus_error
yue-fred-gao Aug 13, 2025
0b12423
More bogus error message during syncd start
yue-fred-gao Aug 15, 2025
9e45336
Merge branch 'master' into bogus_error
yue-fred-gao Sep 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion vslib/vpp/SaiObjectDB.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,7 +282,7 @@ SaiObjectDB::get(
// check if the object exists
status = m_switch_db->get(object_type, id, 0, &attr);
if (status != SAI_STATUS_SUCCESS) {
SWSS_LOG_WARN("Object is not found in SwitchVpp %s:%s", sai_serialize_object_type(object_type).c_str(), id.c_str());
SWSS_LOG_NOTICE("Object is not found in SwitchVpp %s:%s", sai_serialize_object_type(object_type).c_str(), id.c_str());
return std::shared_ptr<SaiDBObject>();
}
/*
Expand All @@ -309,6 +309,13 @@ SaiObject::get_linked_object(
SWSS_LOG_ERROR("Failed to get attribute %d from object %s", link_attr_id, m_id.c_str());
return std::shared_ptr<SaiDBObject>();
}

if (RealObjectIdManager::objectTypeQuery(attr.value.oid) != linked_object_type) {
SWSS_LOG_INFO("Linked object type mismatch: expected %d, got %d. Will return empty object.",
linked_object_type, RealObjectIdManager::objectTypeQuery(attr.value.oid));
return std::shared_ptr<SaiDBObject>();
}

linked_obj_id = sai_serialize_object_id(attr.value.oid);

return m_switch_db->get_sai_object(linked_object_type, linked_obj_id);
Expand Down
2 changes: 1 addition & 1 deletion vslib/vpp/SwitchVpp.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1341,7 +1341,7 @@ sai_status_t SwitchVpp::get(

if (it == objectHash.end())
{
SWSS_LOG_ERROR("not found %s:%s",
SWSS_LOG_INFO("not found %s:%s",
sai_serialize_object_type(objectType).c_str(),
serializedObjectId.c_str());

Expand Down
8 changes: 4 additions & 4 deletions vslib/vpp/SwitchVppRif.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,11 +154,11 @@ std::string get_intf_name_for_prefix (
is_v6 = (route_entry.destination.addr_family == SAI_IP_ADDR_FAMILY_IPV6) ? true : false;

std::string full_if_name = "";
bool found = vpp_get_intf_name_for_prefix(route_entry.destination, is_v6, full_if_name);
if (found == false)
{
bool found = vpp_get_intf_name_for_prefix(route_entry.destination, is_v6, full_if_name);
if (found == false)
{
auto prefix_str = sai_serialize_ip_prefix(route_entry.destination);
SWSS_LOG_ERROR("host interface for prefix not found: %s", prefix_str.c_str());
SWSS_LOG_INFO("host interface for prefix not found: %s", prefix_str.c_str());
}
return full_if_name;

Expand Down
Loading