Fix duplicate port error in FlexCounter bulk stats collection #1681
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
stephenxs
approved these changes
Nov 3, 2025
Collaborator
|
@kperumalbfn , could you please help to review? |
kperumalbfn
reviewed
Nov 10, 2025
| auto vid = vids[i]; | ||
| auto rid = rids[i]; | ||
|
|
||
| if (ctx.object_vids_set.find(vid) != ctx.object_vids_set.end()) |
There was a problem hiding this comment.
@DavidZagury What are the cases duplicate object-ids present in the bulk set?
Contributor
Author
There was a problem hiding this comment.
@kperumalbfn,
We saw the duplication on a few tests such as test_pfcwd_status, test_pfcwd_interval and test_fdb
I believe there were always duplication - there is nothing stopping that from happening. But, in new version of SAI/SDK in NVIDIA switches there is a new error line regarding this.
kperumalbfn
approved these changes
Nov 19, 2025
DavidZagury
force-pushed
the
master_bulk_remove_duplicate
branch
from
b2c4b0b to
0e5ee8a
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
DavidZagury
force-pushed
the
master_bulk_remove_duplicate
branch
from
0e5ee8a to
f1e81be
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
When PFC Watchdog or other features start collecting bulk statistics, duplicate ports can be added to the bulk stats context Root Cause: ----------- The addBulkStatsContext() functions did not check for duplicate VIDs before adding objects to the bulk context. The object_vids vector could contain the same VID multiple times, leading to duplicate RIDs being passed to the SAI bulk stats API. Solution: --------- 1. Added object_vids_set (unordered_set) to BulkStatsContext 2. Modified both addBulkStatsContext() overloads to check the set before adding new objects 3. Updated removeBulkStatsContext() to maintain set consistency Signed-off-by: david.zagury <[email protected]>
Signed-off-by: david.zagury <[email protected]>
DavidZagury
force-pushed
the
master_bulk_remove_duplicate
branch
from
f1e81be to
ec60958
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When PFC Watchdog or other features start collecting bulk statistics, duplicate ports can be added to the bulk stats context
Root Cause:
The addBulkStatsContext() functions did not check for duplicate VIDs before adding objects to the bulk context. The object_vids vector could contain the same VID multiple times, leading to duplicate RIDs being passed to the SAI bulk stats API.
Solution: