Fix: Add TLV_LIST validation support to meta validation functions#1804
Open
kallal79 wants to merge 1 commit intosonic-net:masterfrom
Open
Fix: Add TLV_LIST validation support to meta validation functions#1804kallal79 wants to merge 1 commit intosonic-net:masterfrom
kallal79 wants to merge 1 commit intosonic-net:masterfrom
Conversation
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This commit addresses issue sonic-net#337 by adding missing support for SAI_ATTR_VALUE_TYPE_TLV_LIST in the meta validation functions. Changes made: - Added SAI_ATTR_VALUE_TYPE_TLV_LIST case to meta_generic_validation_create() - Added SAI_ATTR_VALUE_TYPE_TLV_LIST case to meta_generic_validation_set() - Added SAI_ATTR_VALUE_TYPE_TLV_LIST case to meta_generic_validation_get() - Added SAI_ATTR_VALUE_TYPE_TLV_LIST case to meta_generic_validation_post_remove() The implementation follows the same pattern as other list types (MAP_LIST, IP_ADDRESS_LIST, SEGMENT_LIST) using VALIDATION_LIST and VALIDATION_LIST_GET macros. Test coverage: - Added TestTlvListValidation.cpp for bug condition exploration - Added TestTlvListPreservation.cpp for regression prevention - Updated Makefile.am to include new test files This fix resolves the 'serialization type is not supported yet FIXME' error that was thrown when TLV_LIST attributes were processed in meta validation. Fixes: sonic-net#337 Signed-off-by: kallal79 <kallal79@users.noreply.github.com>
kallal79
force-pushed
the
fix-tlv-list-validation-support
branch
from
cb35dfc to
3f4e531
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Author
|
/azp run |
|
Commenter does not have sufficient privileges for PR 1804 in repo sonic-net/sonic-sairedis |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit addresses issue #337 by adding missing support for SAI_ATTR_VALUE_TYPE_TLV_LIST in the meta validation functions.
Changes made:
The implementation follows the same pattern as other list types (MAP_LIST, IP_ADDRESS_LIST, SEGMENT_LIST) using VALIDATION_LIST and VALIDATION_LIST_GET macros.
Test coverage:
This fix resolves the 'serialization type is not supported yet FIXME' error that was thrown when TLV_LIST attributes were processed in meta validation.
Fixes: #337