syncd: Fix file descriptor leak in MdioIpcServer#1830
Open
theycallmeaabie wants to merge 1 commit intosonic-net:masterfrom
Open
syncd: Fix file descriptor leak in MdioIpcServer#1830theycallmeaabie wants to merge 1 commit intosonic-net:masterfrom
theycallmeaabie wants to merge 1 commit intosonic-net:masterfrom
Conversation
Signed-off-by: theycallmeaabie <theycallmeaabie@gmail.com>
|
|
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a file descriptor leak in syncd’s MDIO IPC server loop by ensuring the directory FD opened to validate the IPC socket directory is properly closed, preventing FD exhaustion during repeated task restarts.
Changes:
- Close the directory file descriptor (
fd) immediately after the directory existence check succeeds inMdioIpcServer::syncd_ipc_task_main().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1829
The directory file descriptor opened via
open(path, O_DIRECTORY)inMdioIpcServer::syncd_ipc_task_main()was never closed on any code path early error returns or normal exit.Changes
fdimmediately after the directory existence check succeeds, since it is not used beyond that pointImpact
Prevents file descriptor exhaustion on repeated IPC task restarts due to socket failures.