[Banner] Added BANNER_MESSAGE table to ConfigDB #826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 20, 2023
liat-grozovik
changed the title
|
@SviatoslavBoichuk please handle conflict and add to PR description code changes and motivation |
SviatoslavBoichuk
force-pushed
the
dev-banner-feature
branch
from
b0f1b8f to
2a62192
Compare
Fixed conflicts, updated PR description |
SviatoslavBoichuk
force-pushed
the
dev-banner-feature
branch
from
2a62192 to
dfb7671
Compare
|
/azpw run sonic-net.sonic-host-services |
|
/AzurePipelines run sonic-net.sonic-host-services |
|
No pipelines are associated with this pull request. |
|
/AzurePipelines run sonic-net.sonic-host-services |
|
Commenter does not have sufficient privileges for PR 826 in repo sonic-net/sonic-swss-common |
qiluo-msft
approved these changes
Feb 12, 2024
liat-grozovik
approved these changes
Apr 16, 2024
|
|
fastiuk
force-pushed
the
dev-banner-feature
branch
from
6305046 to
72c4d6e
Compare
Signed-off-by: Yevhen Fastiuk <[email protected]>
fastiuk
force-pushed
the
dev-banner-feature
branch
from
72c4d6e to
f3812af
Compare
|
/azpw run Azure.sonic-swss-common |
|
@liat-grozovik the checkers finally passed, could you please merge it so I can rerun tests for other repositories? |
|
@qiluo-msft , Can you please merge this PR ? |
arfeigin
pushed a commit
to arfeigin/sonic-swss-common
that referenced
this pull request
Jun 27, 2024
- Why I did it Added Banner feature related Config DB table according to HLD: sonic-net/SONiC#1361 - How I did it Added Banner table name to schema.h. Signed-off-by: Yevhen Fastiuk <[email protected]>
liat-grozovik
pushed a commit
to sonic-net/sonic-host-services
that referenced
this pull request
Oct 21, 2024
…79) - Why I did it Added Banner feature related hostcfgd service according to HLD: sonic-net/SONiC#1361 This PR depends on the following PR: sonic-net/sonic-swss-common#826 - How I did it Added BannerCfg service to hostcfgd. It handles Config DB changes and restart "banner-config" systemd service which will update banners. - How to verify it Manual test Signed-off-by: Yevhen Fastiuk <[email protected]> Co-authored-by: Yevhen Fastiuk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Added Banner feature related Config DB table according to HLD: sonic-net/SONiC#1361
How I did it
Added Banner table name to schema.h.