Add multi-asic support for dropconfig #3735
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
arista-hpandya
force-pushed
the
multi-asic-dropconfig
branch
from
1a8c9ea to
4f38e99
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
arista-hpandya
force-pushed
the
multi-asic-dropconfig
branch
from
1818a66 to
b5a9fcb
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
arista-hpandya
force-pushed
the
multi-asic-dropconfig
branch
from
b5a9fcb to
06444ac
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@arlakshm @wenyiz2021 for awareness |
|
A gentle nudge to review the PR @vmittal-msft @tjchadaga . Thank you! |
vmittal-msft
approved these changes
Feb 18, 2025
|
Thanks for reviewing @vmittal-msft! Here are the snapshots from ToR device testing as requested:
|
|
Thanks. Please go ahead and merge. |
|
Resolved conflict for 202405 cherry-pick: #3775 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
This script was missed during the initial efforts to add multi-asic support.
How I did it
This is in accordance to the issue sonic-net/sonic-buildimage#15148 which tracks the multi-asic support for scripts in sonic-utilities.
How to verify it
The changes were verified by:
Running all the unit tests in sonic-utilities
Verifying the changes manually on a single-asic linecards
Verifying the changes manually on a multi-asic linecards
Screenshots of the manual tests:
Previous command output (if the output of a command-line utility has changed)
Single asic command outputs remain untouched
New command output (if the output of a command-line utility has changed)
New multi asic command outputs will start with the prefix: `For namespace: "