Enhance list-checkpoints CLI #3746
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
xincunli-sonic
changed the title
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
qiluo-msft
reviewed
Feb 1, 2025
| @@ -1825,7 +1825,11 @@ def setUp(self): | |||
| self.any_target_config = {"PORT": {}} | |||
| self.any_target_config_as_text = json.dumps(self.any_target_config) | |||
| self.any_checkpoint_name = "any_checkpoint_name" | |||
| self.any_checkpoints_list = ["checkpoint1", "checkpoint2", "checkpoint3"] | |||
| self.any_checkpoints_list = [ | |||
| {"name": "checkpoint1", "time": datetime.datetime.now(timezone.utc).isoformat()}, | |||
wen587
reviewed
Feb 6, 2025
tests/config_test.py
Outdated
| @@ -1825,7 +1825,11 @@ def setUp(self): | |||
| self.any_target_config = {"PORT": {}} | |||
| self.any_target_config_as_text = json.dumps(self.any_target_config) | |||
| self.any_checkpoint_name = "any_checkpoint_name" | |||
| self.any_checkpoints_list = ["checkpoint1", "checkpoint2", "checkpoint3"] | |||
| self.any_checkpoints_list = [ | |||
There was a problem hiding this comment.
Will it has command show change?
e.g.
Current command output:
admin@str3-msn4280-02:~$ sudo config checkpoint test
...
Checkpoint created successfully.
admin@str3-msn4280-02:~$ sudo config checkpoint test1
...
Checkpoint created successfully.
admin@str3-msn4280-02:~$ sudo config list-checkpoints
[
"test1",
"test"
]
admin@str3-msn4280-02:~$ sudo config rollback test
...
What would it be after this change? Especially when rollback
| @@ -244,14 +245,29 @@ def list_checkpoints(self): | |||
| self.logger.log_info("Getting checkpoints in checkpoints directory.") | |||
| checkpoint_names = self.util.get_checkpoint_names() | |||
|
|
|||
| checkpoints_len = len(checkpoint_names) | |||
| self.logger.log_info(f"Found {checkpoints_len} checkpoint{'s' if checkpoints_len != 1 else ''}{':' if checkpoints_len > 0 else '.'}") | |||
| checkpoints = [] | |||
There was a problem hiding this comment.
do you need to run sonic-mgmt test as well, since 'config list-checkpoints' is used in test code https://github.com/search?q=repo%3Asonic-net%2Fsonic-mgmt%20config%20list-checkpoints&type=code
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Add a new parameter
-tto add last modify datetime of each checkpoint to the list-checkpoint CLI.ADO: 30788686
How I did it
Read each checkpoint file last modify time, return checkpoint name and its last modify datetime
[ {"name": "checkpoint1", "time": "timestamp"}, {"name": "checkpoint2", "time": "timestamp"} ]How to verify it
Applied change to lab device, then run
sudo config list-checkpointsPrevious command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)