Fix vnet_route_check for active and inactive routes, add --all option
#3763
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… we will not check whether inactive APP DB VNET routes are in ASIC DB or not. Added mock tests to test this behavior. Signed-off-by: Mahdi Ramezani <[email protected]>
Signed-off-by: Mahdi Ramezani <[email protected]>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@mramezani95 , can you provide a sample output before and after this fix? |
|
@PrasadSamudrala, please review |
mramezani95
changed the title
-a and --all to scripts/vnet_route_check.pyvnet_route_check for active and inactive routes, add --all option
Signed-off-by: Mahdi Ramezani <[email protected]>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Mahdi Ramezani <[email protected]>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…s not support it. Signed-off-by: Mahdi Ramezani <[email protected]>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
The format of the output has not changed. This fix only affects which routes are included in the output. Here is an example output: There is no output if there are no discrepancies between VNET routes in ASIC DB and APP DB. |
Signed-off-by: Mahdi Ramezani <[email protected]>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
prsunny
reviewed
Feb 18, 2025
Signed-off-by: Mahdi Ramezani <[email protected]>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
prsunny
previously approved these changes
Feb 18, 2025
Signed-off-by: Mahdi Ramezani <[email protected]>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
qiluo-msft
reviewed
Feb 19, 2025
Signed-off-by: Mahdi Ramezani <[email protected]>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Mahdi Ramezani <[email protected]>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
FengPan-Frank
approved these changes
Feb 20, 2025
qiluo-msft
approved these changes
Feb 20, 2025
|
@kperumalbfn , please take this fix for next 202411 image |
|
@prsunny Added to 202411 |
|
Cherry-pick PR to 202411: #3780 |
mssonicbld
added
Included in 202411 Branch
and removed
Created PR to 202411 Branch
labels
|
@mramezani95 Can you open a direct PR to 202405 to address conflict? |
mramezani95
added a commit
to mramezani95/sonic-utilities
that referenced
this pull request
Mar 14, 2025
Signed-off-by: Mahdi Ramezani <[email protected]>
bingwang-ms
pushed a commit
that referenced
this pull request
Mar 22, 2025
…--all` option (#3808) * Ported from PR #3763 for the master branch. Signed-off-by: Mahdi Ramezani <[email protected]>
nmoray
pushed a commit
to nmoray/sonic-utilities
that referenced
this pull request
Jun 25, 2025
…tion (sonic-net#3763) What I did Added the options -a and --all to scripts/vnet_route_check.py. Both options are equivalent. If none of them is provided, then when finding the VNET routes that are in APP DB but not in ASIC DB, we will ignore routes in APP DB that are not active. Mock tests in tests/test_vnet_route_check.py are added to test this behavior. How I did it If -a and --all are not provided, we first filter routes in APP DB to find active routes and then check which active routes are not in ASIC DB. The status of each route is retrieved from STATE DB. If a route is not found in STATE DB, then it is considered to be active. How to verify it You can verify the behavior by running mock tests in tests/test_vnet_route_check.py, or by manually running the vnet_route_check.py script on a DUT.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Added the options
-aand--alltoscripts/vnet_route_check.py. Both options are equivalent. If none of them is provided, then when finding the VNET routes that are in APP DB but not in ASIC DB, we will ignore routes in APP DB that are not active.Mock tests in
tests/test_vnet_route_check.pyare added to test this behavior.How I did it
If
-aand--allare not provided, we first filter routes in APP DB to find active routes and then check which active routes are not in ASIC DB. The status of each route is retrieved from STATE DB. If a route is not found in STATE DB, then it is considered to be active.How to verify it
You can verify the behavior by running mock tests in
tests/test_vnet_route_check.py, or by manually running thevnet_route_check.pyscript on a DUT.Previous command output (if the output of a command-line utility has changed)
N/A
New command output (if the output of a command-line utility has changed)
N/A