Skip to content

[Fast-linkup] Added CLIs for config/show #4182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
YairRaviv wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

[Fast-linkup] Added CLIs for config/show #4182

YairRaviv wants to merge 1 commit into from

Conversation

@YairRaviv
Copy link
Contributor

@YairRaviv YairRaviv commented Jan 7, 2026 •
edited
Loading

HLD: fast-link-up-hld.md

What I did

Implemented CLI for Fast-linkup feature including:

  • config feature parameters
  • enable/disable the feature per-port
  • show feature parameters
  • show interfaces feature status

How I did it

  • By adding the new command support to config and show CLI

How to verify it

  • Run Fast-linkup CLIs

New command output (if the output of a command-line utility has changed)

admin@sonic:/home/admin# show switch-fast-linkup global
+---------------+---------+
| Field         |   Value |
+===============+=========+
| ber_threshold |      10 |
+---------------+---------+
| guard_time    |      15 |
+---------------+---------+
| polling_time  |      60 |
+---------------+---------+

admin@sonic:/home/admin# show interfaces fast-linkup status
+-------------+---------------+
| Interface   | fast_linkup   |
+=============+===============+
| Ethernet0   | true          |
| Ethernet4   | true          |
| Ethernet8   | true          |
| Ethernet12  | false         |
| Ethernet16  | false         |
| Ethernet20  | false         |
| Ethernet24  | false         |
| Ethernet28  | false         |
| Ethernet32  | false         |
| Ethernet36  | false         |
| Ethernet40  | false         |
| Ethernet44  | false         |
| Ethernet48  | false         |
| Ethernet52  | false         |
| Ethernet56  | false         |
| Ethernet60  | false         |
| Ethernet64  | false         |
| Ethernet68  | false         |
| Ethernet72  | false         |
| Ethernet76  | false         |
| Ethernet80  | false         |
| Ethernet84  | false         |
| Ethernet88  | false         |
| Ethernet92  | false         |
| Ethernet96  | false         |
| Ethernet100 | false         |
| Ethernet104 | false         |
| Ethernet108 | false         |
| Ethernet112 | false         |
| Ethernet116 | false         |
| Ethernet120 | false         |
| Ethernet124 | false         |
+-------------+---------------+

@mssonicbld
Copy link
Collaborator

mssonicbld commented Jan 7, 2026

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Jan 7, 2026

Azure Pipelines successfully started running 1 pipeline(s).

@YairRaviv YairRaviv mentioned this pull request Jan 7, 2026
Draft
@YairRaviv YairRaviv force-pushed the yraviv-fast-linkup-sonic-utilities branch from ba03a54 to 2881c71 Compare January 7, 2026 12:04
@mssonicbld
Copy link
Collaborator

mssonicbld commented Jan 7, 2026

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Jan 7, 2026

Azure Pipelines successfully started running 1 pipeline(s).

@YairRaviv YairRaviv force-pushed the yraviv-fast-linkup-sonic-utilities branch from 2881c71 to 00800c5 Compare January 7, 2026 12:07
@mssonicbld
Copy link
Collaborator

mssonicbld commented Jan 7, 2026

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Jan 7, 2026

Azure Pipelines successfully started running 1 pipeline(s).

@YairRaviv YairRaviv force-pushed the yraviv-fast-linkup-sonic-utilities branch from 00800c5 to 6bec417 Compare January 7, 2026 12:11
@mssonicbld
Copy link
Collaborator

mssonicbld commented Jan 7, 2026

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Jan 7, 2026

Azure Pipelines successfully started running 1 pipeline(s).

@YairRaviv YairRaviv force-pushed the yraviv-fast-linkup-sonic-utilities branch from 6bec417 to 3524454 Compare January 7, 2026 12:12
@mssonicbld
Copy link
Collaborator

mssonicbld commented Jan 7, 2026

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Jan 7, 2026

Azure Pipelines successfully started running 1 pipeline(s).

@YairRaviv YairRaviv force-pushed the yraviv-fast-linkup-sonic-utilities branch from 3524454 to 9df5b8a Compare January 7, 2026 12:31
@mssonicbld
Copy link
Collaborator

mssonicbld commented Jan 7, 2026

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Jan 7, 2026

Azure Pipelines successfully started running 1 pipeline(s).

@YairRaviv YairRaviv force-pushed the yraviv-fast-linkup-sonic-utilities branch from 9df5b8a to ab914aa Compare January 7, 2026 12:48
@mssonicbld
Copy link
Collaborator

mssonicbld commented Jan 7, 2026

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Jan 7, 2026

Azure Pipelines successfully started running 1 pipeline(s).

@YairRaviv YairRaviv force-pushed the yraviv-fast-linkup-sonic-utilities branch from ab914aa to 9b7b3d6 Compare January 7, 2026 14:33
@mssonicbld
Copy link
Collaborator

mssonicbld commented Jan 7, 2026

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Jan 7, 2026

Azure Pipelines successfully started running 1 pipeline(s).

@YairRaviv YairRaviv force-pushed the yraviv-fast-linkup-sonic-utilities branch from 9b7b3d6 to 620bf18 Compare January 7, 2026 15:20
@mssonicbld
Copy link
Collaborator

mssonicbld commented Jan 7, 2026

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Jan 7, 2026

Azure Pipelines successfully started running 1 pipeline(s).

@YairRaviv YairRaviv force-pushed the yraviv-fast-linkup-sonic-utilities branch from 620bf18 to 1a76a73 Compare January 7, 2026 15:23
@mssonicbld
Copy link
Collaborator

mssonicbld commented Jan 7, 2026

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Jan 7, 2026

Azure Pipelines successfully started running 1 pipeline(s).

@YairRaviv YairRaviv force-pushed the yraviv-fast-linkup-sonic-utilities branch from 1a76a73 to b1a8c67 Compare January 7, 2026 16:30
@mssonicbld
Copy link
Collaborator

mssonicbld commented Jan 7, 2026

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Jan 7, 2026

Azure Pipelines successfully started running 1 pipeline(s).

@YairRaviv YairRaviv force-pushed the yraviv-fast-linkup-sonic-utilities branch from b1a8c67 to 39af35f Compare January 7, 2026 17:38
@mssonicbld
Copy link
Collaborator

mssonicbld commented Jan 7, 2026

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Jan 7, 2026

Azure Pipelines successfully started running 1 pipeline(s).

abelamit
abelamit reviewed Jan 8, 2026
View reviewed changes
config/main.py
# Load existing configuration to preserve unspecified values
existing = db.cfgdb.get_entry('SWITCH_FAST_LINKUP', 'GLOBAL') or {}

def to_int(val):
Copy link

@abelamit abelamit Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove function - better to integrate into code and to verification on variables in the beginning of the function

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@abelamit abelamit abelamit left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@YairRaviv @mssonicbld @abelamit