Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SDP session ID length limitation #438

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

lo-simon
Copy link
Collaborator

@lo-simon lo-simon commented Mar 7, 2025

According to the RFC 4566 5.2. Origin

<sess-id> is a numeric string such that the tuple of <username>,
 
<sess-id>, <nettype>, <addrtype>, and <unicast-address> forms a
 
globally unique identifier for the session.  The method of
 
<sess-id> allocation is up to the creating tool, but it has been
 
suggested that a Network Time Protocol (NTP) format timestamp be
 
used to ensure uniqueness [[13](https://datatracker.ietf.org/doc/html/rfc4566#ref-13)].

The current implementation limit for the session ID is UINT64_MAX (18446744073709551615), i.e., its maximum length is 20 digits. To fulfill the RFC above, the string should not be limited in length.

@garethsb
Copy link
Contributor

garethsb commented Mar 7, 2025

This is at the least incomplete since the same argument applies to sess-version.

@lo-simon
Copy link
Collaborator Author

lo-simon commented Mar 7, 2025

This is at the least incomplete since the same argument applies to sess-version.

Well spotted @garethsb. Will extend the change to sess-version.

Co-authored-by: Gareth Sylvester-Bradley <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants