Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export JetBrainsMono font #405

Open
wants to merge 3 commits into
base: next
Choose a base branch
from
Open

Export JetBrainsMono font #405

wants to merge 3 commits into from

Conversation

antyas
Copy link

@antyas antyas commented Mar 31, 2022

No description provided.

0x009922
0x009922 approved these changes Apr 1, 2022
View reviewed changes
Copy link
Contributor

@0x009922 0x009922 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's fine, but it would be nice to add a test to test/lib-exports.spec.ts (permalink) for it

@0x009922 0x009922 added the next Related to next lib iteration, i.e. based on Vue 3 label Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefashkaa stefashkaa stefashkaa approved these changes

@0x009922 0x009922 0x009922 approved these changes

@Ctepan Ctepan Awaiting requested review from Ctepan

@timofeytrepalin timofeytrepalin Awaiting requested review from timofeytrepalin

Assignees
No one assigned
Labels
next Related to next lib iteration, i.e. based on Vue 3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@antyas @stefashkaa @0x009922