[Fix] Minor fixes

soramitsu · Jul 10, 2024 · ad622a1 · ad622a1
1 parent 942d932
commit ad622a1
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/contracts/interfaces/IFactories/IGenericFactory.sol b/contracts/interfaces/IFactories/IGenericFactory.sol
@@ -2,7 +2,7 @@
 pragma solidity 0.8.25;
 
 /// @title Generic Factory Interface
-/// @notice Defines the main errors and events used in all inhereted factories from the generic one.
+/// @notice Defines the main errors and events used in all inherited factories from the generic one.
 /// @dev This interface is used in a GenericFactory contract which is inherited by the other specific factory contracts.
 interface IGenericFactory {
     /// @notice Error to indicate when an invalid request manager contract's address was submitted.

diff --git a/test/ERC20LockUpStakingPool.test.ts b/test/ERC20LockUpStakingPool.test.ts
@@ -153,7 +153,7 @@ describe("Contract Deployment", async function () {
       }
 
       let lengthBefore = (await requestManager.getRequests()).length;
-      await expect(requestManager.connect(user_A).requestDeployment(requestPayload)).to.be.revertedWithCustomError(requestManager, "InvalidIpfsHash");
+      await expect(requestManager.connect(user_A).requestDeployment(requestPayload)).to.be.revertedWithCustomError(requestManager, "IpfsZeroHash");
       let length = (await requestManager.getRequests()).length;
       expect(lengthBefore).to.be.equal(length);
     });
@@ -167,7 +167,7 @@ describe("Contract Deployment", async function () {
       }
 
       let lengthBefore = (await requestManager.getRequests()).length;
-      await expect(requestManager.connect(user_A).requestDeployment(requestPayload)).to.be.revertedWithCustomError(requestManager, "InvalidPayload");
+      await expect(requestManager.connect(user_A).requestDeployment(requestPayload)).to.be.revertedWithCustomError(requestManager, "EmptyPayload");
       let length = (await requestManager.getRequests()).length;
       expect(lengthBefore).to.be.equal(length);
     });
@@ -258,11 +258,11 @@ describe("Contract Deployment", async function () {
       expect(req.requestStatus).to.be.equal(3);
     });
 
-    it("Deploy failed: invalid caller", async function () {
+    it("Deploy failed: invalid deployer", async function () {
       let length = (await requestManager.getRequests()).length;
       let req = await requestManager.requests(length - 1);
       expect(req.requestStatus).to.be.equal(3);
-      await expect(requestManager.connect(user_B).deploy(length - 1)).to.be.revertedWithCustomError(requestManager, "InvalidCaller");
+      await expect(requestManager.connect(user_B).deploy(length - 1)).to.be.revertedWithCustomError(requestManager, "InvalidDeployer");
     });
 
     it("Deploy failed: invalid id", async function () {