Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft version of smart contracts #13

Merged
merged 90 commits into from
May 14, 2024
Merged

Draft version of smart contracts #13

merged 90 commits into from
May 14, 2024

Conversation

SergeyPoslavskiy
Copy link
Contributor

No description provided.

Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slither found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 15.06524% with 716 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (master@3b44c49). Click here to learn what that means.

Files Patch % Lines
contracts/pools/ERC20PenaltyFeePool.sol 0.00% 109 Missing ⚠️
contracts/pools/ERC721/ERC721PenaltyFeePool.sol 0.00% 108 Missing ⚠️
contracts/pools/ERC721/ERC721LockUpStakingPool.sol 0.00% 98 Missing ⚠️
...ntracts/pools/ERC721/ERC721NoLockUpStakingPool.sol 0.00% 92 Missing ⚠️
contracts/pools/ERC20NoLockUpStakingPool.sol 0.00% 81 Missing ⚠️
contracts/factories/ERC20NoLockUpFactory.sol 0.00% 45 Missing ⚠️
contracts/factories/ERC721NoLockUpFactory.sol 0.00% 45 Missing ⚠️
contracts/factories/ERC721LockUpFactory.sol 0.00% 43 Missing ⚠️
contracts/factories/ERC20PenaltyFeeFactory.sol 0.00% 41 Missing ⚠️
contracts/factories/ERC721PenaltyFeeFactory.sol 0.00% 41 Missing ⚠️
... and 3 more
Additional details and impacted files
@@            Coverage Diff            @@
##             master      #13   +/-   ##
=========================================
  Coverage          ?   15.06%           
=========================================
  Files             ?       13           
  Lines             ?      843           
  Branches          ?      222           
=========================================
  Hits              ?      127           
  Misses            ?      716           
  Partials          ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SergeyPoslavskiy SergeyPoslavskiy changed the title Develop merge Draft version of smart contracts May 14, 2024
@SergeyPoslavskiy SergeyPoslavskiy added the enhancement New feature or request label May 14, 2024
@SergeyPoslavskiy SergeyPoslavskiy added this to the draft release milestone May 14, 2024
@SergeyPoslavskiy SergeyPoslavskiy merged commit e55b69d into master May 14, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants