[Update] merge PenaltyClaim() with Claim() #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #33 +/- ##
========================================
Coverage 21.82% 21.82%
========================================
Files 9 9
Lines 582 582
Branches 153 132 -21
========================================
Hits 127 127
Misses 455 455 ☔ View full report in Codecov by Sentry. |
SergeyPoslavskiy
approved these changes
Jun 17, 2024
| */ | ||
| event Claim(address indexed user, uint256 amount); | ||
| event Claim( |
There was a problem hiding this comment.
Remove totalPenalties and merge
| * @param penaltyAmount The amount deducted as penalty fee | ||
| * @param totalPenalties The total amount of deducted penalty fee | ||
| */ | ||
| event Claim( |
There was a problem hiding this comment.
Remove totalPenalties and merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge
PenaltyClaim()event intoClaim()