Develop into refactor branch #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Feature/code refactor
… claim in penalty pool
…nalty_pool_claim
…fy_script [Script] Add script to request deployment and verify contract
…nalty_pool_claim [Update] add PenaltyClaim event in ERC721
…laim_ [Update] merge PenaltyClaim() with Claim()
…laim_ [Update] removed totalPenalties in claim event
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+196
to
+202
| function claimFee() external nonReentrant onlyAdmin { | ||
| uint256 penaltyAmount = pool.totalPenalties; | ||
| if (penaltyAmount == 0) revert NothingToClaim(); | ||
| pool.totalPenalties = 0; | ||
| IERC20(pool.rewardToken).safeTransfer(pool.adminWallet, penaltyAmount); | ||
| emit FeeClaim(penaltyAmount); | ||
| } |
Check warning
Code scanning / Slither
Dangerous strict equalities Medium
Comment on lines
+196
to
+202
| function claimFee() external nonReentrant onlyAdmin { | ||
| uint256 penaltyAmount = pool.totalPenalties; | ||
| if (penaltyAmount == 0) revert NothingToClaim(); | ||
| pool.totalPenalties = 0; | ||
| IERC20(pool.rewardToken).safeTransfer(pool.adminWallet, penaltyAmount); | ||
| emit FeeClaim(penaltyAmount); | ||
| } |
Check notice
Code scanning / Slither
Block timestamp Low
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.