Extend Mathsat5 Native Wrapper with API for Proofs #460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| public static native int msat_proof_id(long proof); | ||
|
|
||
| // Cleans up the proof manager and the associated proof | ||
| public static native void msat_destroy_proof_manager(long proofMgr); |
There was a problem hiding this comment.
Request for information, not for action: Are all those methods also available in OptiMathSAT-API or were they added to MathSAT after year 2022?
There was a problem hiding this comment.
The API is from 2012, so it should work.
kfriedberger
approved these changes
Mar 19, 2025
|
I found a small problem and fixed it. A new version would be nice once you have the time. @gcarpio21 is currently working on adding a common proof format and MathSAT5 is a good addition. |
The return-value for an invalid argument needs to match VOID if the function-call itself has VOID return type.
The new version comes with proof-support in the API.
The new version comes with proof-support in the API.
kfriedberger
approved these changes
Mar 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends the Mathsat5 wrapper with API for proofs and adds a small native test for them.
Unfortunately this came up after the merge of the most recent changes. Sorry about that.