fix: file empty on mv #44

adarsh-ecov-dev · 2025-02-11T07:38:53Z

Related Issue(s): #
#42

Proposed Changes:

Created a custom copy_object function to interact with s3
Handled server to server copy interaction in put api flow

PR Checklist:

This PR is made against the dev branch (all proposed changes except releases should be against dev, not main).
This PR has no breaking changes.
This PR contains only one commit.
I have updated or added new tests to cover the changes in this PR.
All tests are passing.
This PR affects the Source Cooperative Frontend & API,
and I have opened issue/PR #XXX to track the change.

Signed-off-by: Navdeep Gupta <[email protected]>

* fix: add more permissions for release-please. Signed-off-by: Navdeep Gupta <[email protected]> * fix: use app token. Signed-off-by: Navdeep Gupta <[email protected]> * fix: release pipeline. Signed-off-by: Navdeep Gupta <[email protected]> * fix: release config. Signed-off-by: Navdeep Gupta <[email protected]> * feat: add deploy pipeline. Signed-off-by: Navdeep Gupta <[email protected]> * feat: platforms. Signed-off-by: Navdeep Gupta <[email protected]> --------- Signed-off-by: Navdeep Gupta <[email protected]>

…#13) Signed-off-by: Navdeep Gupta <[email protected]>

* fix: deploy pipeline. Signed-off-by: Navdeep Gupta <[email protected]> * fix: region. Signed-off-by: Navdeep Gupta <[email protected]> * fix: remove unused variable. Signed-off-by: Navdeep Gupta <[email protected]> * fix: region. Signed-off-by: Navdeep Gupta <[email protected]> * feat: add ecs update service step in deploy pipeline. Signed-off-by: Navdeep Gupta <[email protected]> * fix: cache cargo artifacts. Signed-off-by: Navdeep Gupta <[email protected]> * fix: switched cache action. Signed-off-by: Navdeep Gupta <[email protected]> * fix: version. Signed-off-by: Navdeep Gupta <[email protected]> * fix: workflow. Signed-off-by: Navdeep Gupta <[email protected]> * fix: platform. Signed-off-by: Navdeep Gupta <[email protected]> * fix: add dev pipeline. Signed-off-by: Navdeep Gupta <[email protected]> * fix: tag. Signed-off-by: Navdeep Gupta <[email protected]> * fix: docker build. Signed-off-by: Navdeep Gupta <[email protected]> --------- Signed-off-by: Navdeep Gupta <[email protected]>

Signed-off-by: Navdeep Gupta <[email protected]>

* fix: changed max keys to 1000 for list objects call. Signed-off-by: Navdeep Gupta <[email protected]> * fix: fixed the unwanted redundancy. Signed-off-by: Navdeep Gupta <[email protected]> --------- Signed-off-by: Navdeep Gupta <[email protected]>

Signed-off-by: Navdeep Gupta <[email protected]>

* fix: Added changes to log in json format. Signed-off-by: Navdeep Gupta <[email protected]> * fix: add apache logger. Signed-off-by: Navdeep Gupta <[email protected]> --------- Signed-off-by: Navdeep Gupta <[email protected]>

* fix: Fixed the slow response of the ListObjects call. (#32) * fix: Handled the range request from boto3 for range validation. Signed-off-by: Navdeep Gupta <[email protected]> * fix: content range header. Signed-off-by: Navdeep Gupta <[email protected]> * feat: Added a release pipeline. (#11) Signed-off-by: Navdeep Gupta <[email protected]> * feat: Added deploy pipeline. (#18) * fix: add more permissions for release-please. Signed-off-by: Navdeep Gupta <[email protected]> * fix: use app token. Signed-off-by: Navdeep Gupta <[email protected]> * fix: release pipeline. Signed-off-by: Navdeep Gupta <[email protected]> * fix: release config. Signed-off-by: Navdeep Gupta <[email protected]> * feat: add deploy pipeline. Signed-off-by: Navdeep Gupta <[email protected]> * feat: platforms. Signed-off-by: Navdeep Gupta <[email protected]> --------- Signed-off-by: Navdeep Gupta <[email protected]> * fix: Fixed the issue in character encoding/decoding for request path. (#13) Signed-off-by: Navdeep Gupta <[email protected]> * feat: Added deploy pipeline for dev and prod environments. (#19) * fix: deploy pipeline. Signed-off-by: Navdeep Gupta <[email protected]> * fix: region. Signed-off-by: Navdeep Gupta <[email protected]> * fix: remove unused variable. Signed-off-by: Navdeep Gupta <[email protected]> * fix: region. Signed-off-by: Navdeep Gupta <[email protected]> * feat: add ecs update service step in deploy pipeline. Signed-off-by: Navdeep Gupta <[email protected]> * fix: cache cargo artifacts. Signed-off-by: Navdeep Gupta <[email protected]> * fix: switched cache action. Signed-off-by: Navdeep Gupta <[email protected]> * fix: version. Signed-off-by: Navdeep Gupta <[email protected]> * fix: workflow. Signed-off-by: Navdeep Gupta <[email protected]> * fix: platform. Signed-off-by: Navdeep Gupta <[email protected]> * fix: add dev pipeline. Signed-off-by: Navdeep Gupta <[email protected]> * fix: tag. Signed-off-by: Navdeep Gupta <[email protected]> * fix: docker build. Signed-off-by: Navdeep Gupta <[email protected]> --------- Signed-off-by: Navdeep Gupta <[email protected]> * fix: cache shared among environments. Signed-off-by: Navdeep Gupta <[email protected]> * fix: check for empty access key id. (#6) Signed-off-by: Navdeep Gupta <[email protected]> * fix: latest version. Signed-off-by: Navdeep Gupta <[email protected]> * fix: Fixed issues in listing bucket at account level. (#26) Signed-off-by: Navdeep Gupta <[email protected]> * Merge branch 'main' into dev Signed-off-by: Navdeep Gupta <[email protected]> * fix: update dev deploy workflow to use amd64 platform. Signed-off-by: Navdeep Gupta <[email protected]> * fix: update prod deploy workflow to platform amd64. Signed-off-by: Navdeep Gupta <[email protected]> * fix: changed max keys to 1000 for list objects call. (#31) * fix: changed max keys to 1000 for list objects call. Signed-off-by: Navdeep Gupta <[email protected]> * fix: fixed the unwanted redundancy. Signed-off-by: Navdeep Gupta <[email protected]> --------- Signed-off-by: Navdeep Gupta <[email protected]> --------- Signed-off-by: Navdeep Gupta <[email protected]> * chore(main): release 0.1.20 (#33) Co-authored-by: source-coop-release[bot] <187876225+source-coop-release[bot]@users.noreply.github.com> * feature list bucket accounts api --------- Signed-off-by: Navdeep Gupta <[email protected]> Co-authored-by: navdeepg2021 <[email protected]> Co-authored-by: source-coop-release[bot] <187876225+source-coop-release[bot]@users.noreply.github.com>

…into dev

amit-ecovoice · 2025-02-12T19:38:05Z

src/backends/s3.rs

+                            .unwrap_or_else(|_| bytes::Bytes::from(vec![]));
+                        match self
+                            .put_object(key.clone(), content_bytes, result.content_type)
+                            .await


In a move command, it's put and then delete. I don't see delete logic here.

navdeepg2021 and others added 29 commits November 7, 2024 07:25

fix: Handled the range request from boto3 for range validation.

23a1ceb

Signed-off-by: Navdeep Gupta <[email protected]>

fix: content range header.

399c823

Signed-off-by: Navdeep Gupta <[email protected]>

Merge pull request #8 from source-cooperative/nav/fix-boto-download-bug

53c8ae3

feat: Added a release pipeline. (#11)

5214b5f

Signed-off-by: Navdeep Gupta <[email protected]>

fix: Fixed the issue in character encoding/decoding for request path. (…

8133317

…#13) Signed-off-by: Navdeep Gupta <[email protected]>

Merge branch 'main' into dev

e5a06fc

fix: cache shared among environments.

12845d2

Signed-off-by: Navdeep Gupta <[email protected]>

fix: check for empty access key id. (#6)

0d30c9f

Signed-off-by: Navdeep Gupta <[email protected]>

fix: latest version.

991c0b8

Signed-off-by: Navdeep Gupta <[email protected]>

Merge branch 'main' into dev

bd51d16

fix: Fixed issues in listing bucket at account level. (#26)

e847045

Signed-off-by: Navdeep Gupta <[email protected]>

Merge branch 'main' into dev

772acfb

Signed-off-by: Navdeep Gupta <[email protected]>

fix: update dev deploy workflow to use amd64 platform.

d8e4974

Signed-off-by: Navdeep Gupta <[email protected]>

fix: update prod deploy workflow to platform amd64.

ae79c0d

Signed-off-by: Navdeep Gupta <[email protected]>

Merge branch 'main' into dev

8049cf1

Signed-off-by: Navdeep Gupta <[email protected]>

Merge branch 'main' into dev

02eb14a

chore: enable multi region support.

e0bd2d2

Signed-off-by: Navdeep Gupta <[email protected]>

fix: Added changes to log in json format. (#36)

7db153a

Signed-off-by: Navdeep Gupta <[email protected]>

chore: add apache logger with identity. (#37)

fa28cf9

* fix: Added changes to log in json format. Signed-off-by: Navdeep Gupta <[email protected]> * fix: add apache logger. Signed-off-by: Navdeep Gupta <[email protected]> --------- Signed-off-by: Navdeep Gupta <[email protected]>

feature list account on main call (#43)

e4c39fe

fix: update default repoId & accId for dev env

f40980d

Added logs for signature issue.

190a35a

Added logs for signature issue.

44f0c33

Merge branch 'dev' of github.com:source-cooperative/data.source.coop …

063190f

…into dev

fix: file empty on mv

5065d1e

adarsh-ecov-dev requested a review from amit-ecovoice February 11, 2025 07:39

adarsh-ecov-dev requested a review from venkat-ecov-dev February 11, 2025 07:39

adarsh-ecov-dev assigned venkat-ecov-dev Feb 11, 2025

amit-ecovoice requested changes Feb 12, 2025

View reviewed changes

venkat-ecov-dev force-pushed the dev branch from eeac3fc to 02eb14a Compare February 12, 2025 21:56

venkat-ecov-dev force-pushed the dev branch from 62effff to 0d50163 Compare February 26, 2025 23:39

venkat-ecov-dev closed this Feb 27, 2025

venkat-ecov-dev deleted the adarsh/fix-move-file-empty-issue branch March 12, 2025 08:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: file empty on mv #44

fix: file empty on mv #44

adarsh-ecov-dev commented Feb 11, 2025 •

edited

Loading

amit-ecovoice Feb 12, 2025

fix: file empty on mv #44

fix: file empty on mv #44

Conversation

adarsh-ecov-dev commented Feb 11, 2025 • edited Loading

amit-ecovoice Feb 12, 2025

Choose a reason for hiding this comment

adarsh-ecov-dev commented Feb 11, 2025 •

edited

Loading