Skip to content

Add filterbox in Staged area, same as in Unstaged area #1153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

goran-w
Copy link
Contributor

@goran-w goran-w commented Apr 4, 2025

Implements #1155.

Adds a searchfilter-box, identical to the one in the Unstaged area.

Also adds a RaiseException if committing with a Staged-filter active, since otherwise more changes than the visible ones could be committed. NOTE: This could be made into a warning-dialog with options "Continue? Yes / No", similar to ConfirmCommitWithoutFiles().

…area

Also added minimal handling (RaiseException) if trying to commit with active filter (might commit more changes than visible, so disallow).
Minor unification in unstageChanges() to make it more similar to StageChanges().
@goran-w goran-w changed the base branch from master to develop April 4, 2025 09:52
@love-linger
Copy link
Collaborator

I'll check this PR later.

@love-linger love-linger self-assigned this Apr 7, 2025
@love-linger love-linger added the enhancement New feature or request label Apr 7, 2025
@love-linger love-linger merged commit a37c6b2 into sourcegit-scm:develop Apr 7, 2025
love-linger added a commit that referenced this pull request Apr 7, 2025
- use a single filter for both unstage and staged files
- show confirm dialog if staged files are displayed partially

Signed-off-by: leo <[email protected]>
@goran-w goran-w deleted the filterbox-in-staged-area branch April 7, 2025 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants