-
-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for new NodeSource repository + Node 18.x #275
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only keep distros currently supported by NodeSource We should test with Amazon Linux 2023 when Chef and Bento support it
We use the legacy apt-key only when the [signed-by] syntax is not available
If you can copy the kitchen dokken from java (if it isn't already) that'd be great. |
Isn't this supposed to be handled automatically, via @kitchen-porter, like the last time ? |
Thank you. I've taken this work and credited you on #283 |
You're welcome, thanks for your review and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The NodeSource project has launched a new DEB & RPM unified repository under the
nodistro
codename, using a new GPG signing key. The APT repository (Debian, Ubuntu) should also not use deprecatedapt-key
anymore. Also this cookbook should at minimum support test installing NodeJS 18.x (currently supported) and drop 17.x (not supported).Issues Resolved
nodistro
package repositoryCheck List
## Unreleased
Remarks