Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Socket address in protobuf #1065

Merged
merged 1 commit into from
Feb 2, 2024
Merged

Conversation

Keksoj
Copy link
Contributor

@Keksoj Keksoj commented Jan 30, 2024

two types are used:

  • std::net::SocketAddr for the whole proxying logic, storing the state, listening on TCP sockets, etc
  • sozu_command_lib::proto::command::SocketAddress (note the full-word ending here) for transmitting socket addresses between clients and main process, between main process and workers

@Keksoj Keksoj added this to the v0.16.0 milestone Jan 30, 2024
@Keksoj Keksoj self-assigned this Jan 30, 2024
@Keksoj Keksoj force-pushed the socket-address-in-protobuf branch 3 times, most recently from 883d383 to d413a5a Compare January 31, 2024 10:39
@Keksoj Keksoj force-pushed the socket-address-in-protobuf branch 3 times, most recently from 41e3c16 to 5ff5aee Compare February 1, 2024 15:28
Copy link
Collaborator

@FlorentinDUBOIS FlorentinDUBOIS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems ok?

@Keksoj Keksoj force-pushed the socket-address-in-protobuf branch from 5ff5aee to 413aa57 Compare February 2, 2024 13:13
@Keksoj Keksoj force-pushed the socket-address-in-protobuf branch from 413aa57 to fb11245 Compare February 2, 2024 15:05
@FlorentinDUBOIS FlorentinDUBOIS merged commit 486bbe7 into main Feb 2, 2024
13 checks passed
@FlorentinDUBOIS FlorentinDUBOIS deleted the socket-address-in-protobuf branch February 2, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants