Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(command): do not override subject and san of certificate when loading configuration from file #1105

Merged
merged 1 commit into from
May 29, 2024
Merged

fix(command): do not override subject and san of certificate when loading configuration from file #1105

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion command/src/config.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -919,7 +919,11 @@ impl HttpFrontendConfig {
certificate: self.certificate.clone().unwrap(),
certificate_chain: self.certificate_chain.clone().unwrap_or_default(),
versions: self.tls_versions.iter().map(|v| *v as i32).collect(),
names: vec![self.hostname.clone()],
// This field is used to override the certificate subject and san, we should not set it when
// loading the configuration, as we may provide a wildcard certificate for a specific domain.
// As a result, we will reject legit traffic for others domains as the certificate resolver will
// not load twice the same certificate and then do not register the certificate for others domains.
names: vec![],
},
expired_at: None,
})
Expand Down
Loading