store all certificates, resolve the longer-lived ones #1115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
store all certificates in the CertificateResolver, keep track of the longer-lived ones using the name_fingerprint_idx the unit tests control that the longer-lived certificates are resolved and to fallback on shorter-lived ones if the longer-lived are removed. Co-Authored-By: Eloi DEMOLIS <[email protected]>
Keksoj
force-pushed
the
fix-add-certificate
branch
from
1f7c530 to
8b3462d
Compare
FlorentinDUBOIS
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now, Sōzu replaces shorter-lived certificates when adding a new one.
This behaviour is imperfectly implement, and leads occasionnaly to confusing behaviours: a certificate with 2 domain names would be removed by a 1-domain-name certificate, leaving one of the domain names unresolved.
Instead of fixing the replacement of certificates, this PR changes the behaviour of the
CertificateResolver: