Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: rewritten the image building action #1153

Closed
wants to merge 8 commits into from

Conversation

shanduur
Copy link

I tried to add some fixes to the CI, so the docker image is built and published (now to GHCR) correctly. This can be easily changed in the future, if GHCR does not meet the expectations.

The action should work as is, as it's mostly copy-pasted from my other project.

@CLAassistant
Copy link

CLAassistant commented Nov 15, 2024

CLA assistant check
All committers have signed the CLA.

@shanduur
Copy link
Author

shanduur commented Nov 15, 2024

One more note - once the image is published in the GHCR, it is set to private by default. You will need to make it public here: https://github.com/orgs/sozu-proxy/packages/container/sozu/settings (dead link until publication)

Signed-off-by: Mateusz Urbanek <[email protected]>
Signed-off-by: Mateusz Urbanek <[email protected]>
Signed-off-by: Mateusz Urbanek <[email protected]>
@shanduur
Copy link
Author

One more thing - I added Dependabot config so the dependencies might be updated automatically, but this also needs to be turned on by admins here:
https://github.com/sozu-proxy/sozu/settings/security_analysis

@shanduur shanduur marked this pull request as draft November 15, 2024 14:39
@shanduur
Copy link
Author

Drafting, because even if local build works for me, the GH Action is failing, need to debug it further.

@shanduur
Copy link
Author

Ok, passed on my repo branch, should be good for review now 🔥

@shanduur shanduur marked this pull request as ready for review November 15, 2024 14:59
@Keksoj
Copy link
Contributor

Keksoj commented Nov 20, 2024

This looks very nice, thank you. I have no clue wether GHCR is better than docker hub for our needs.
Would you elaborate on the relevance of GHCR as opposed to Docker Hub ?

Thoughts on Github Container Repository vs Docker hub, @FlorentinDUBOIS ?

@shanduur
Copy link
Author

I selected it only because you do not need to manage the credentials during the build process, rotate it, etc. It's just easily integrated into the whole flow.

@Gontier-Julien
Copy link

+1 for this so i can run it on docker 💯

@FlorentinDUBOIS
Copy link
Collaborator

Hello, we have another pull request that fix the ci without rewriting it,
I have merged this one instead.
Besides, I am updating the credentials to be able to have the docker images available

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants