Skip to content

Commit

Permalink
Pin Navigation2 demo to humble-2024.10.0 (#197)
Browse files Browse the repository at this point in the history
The current dockerfile of the navigation2 demo depends on space-ros:latest.
This may prevent the image from building if we release a new version of Space
ROS but we have not yet adapted the Navigation 2 demo as needed, breaking the
build.

This commit pins the version of the Navigation 2 demo to the latest version of
Space ROS that we have tested it with (humble-2024.10.0). We modify both the
Dockerfile and the build script so that the result is the same (and thus
unsurprising) no matter how the image is built.
  • Loading branch information
ivanperez-keera committed Jan 31, 2025
1 parent 78ff4cb commit 7126d6d
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion navigation2/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
# VERSION - The version of Space ROS (default: "preview")
# SPACE_ROS_IMAGE - The base Space ROS image to build on

ARG SPACE_ROS_IMAGE=osrf/space-ros:latest
ARG SPACE_ROS_IMAGE=osrf/space-ros:humble-2024.10.0

FROM ${SPACE_ROS_IMAGE}

Expand Down
2 changes: 1 addition & 1 deletion navigation2/build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ echo ""
docker build -t $ORG/$IMAGE:$TAG \
--build-arg VCS_REF="$VCS_REF" \
--build-arg VERSION="$VERSION" \
--build-arg SPACE_ROS_IMAGE="${SPACE_ROS_IMAGE:-osrf/space-ros:latest}" \
--build-arg SPACE_ROS_IMAGE="${SPACE_ROS_IMAGE:-osrf/space-ros:humble-2024.10.0}" \
.

echo ""
Expand Down

0 comments on commit 7126d6d

Please sign in to comment.