Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin Space ROS Version Used by Dockerfiles #197

Closed
Bckempa opened this issue Oct 17, 2024 · 0 comments · Fixed by #210
Closed

Pin Space ROS Version Used by Dockerfiles #197

Bckempa opened this issue Oct 17, 2024 · 0 comments · Fixed by #210
Assignees
Labels
enhancement New feature or request

Comments

@Bckempa
Copy link
Contributor

Bckempa commented Oct 17, 2024

Feature description

By pinning the docker files to known working Space ROS releases we ensure that core development doesn't leave demos and stacks in a broken state.

Implementation considerations

Might need an escape hatch to allow building on latest or specified version for testing of upgrades.

Discussed at space-ros/space-ros#223 as a release requirement for jazzy-2024.10.0

@Bckempa Bckempa added the enhancement New feature or request label Oct 17, 2024
@Bckempa Bckempa added this to the jazzy-2024.10.0 milestone Oct 17, 2024
@Bckempa Bckempa self-assigned this Oct 17, 2024
ivanperez-keera added a commit that referenced this issue Jan 31, 2025
The current dockerfile of the moveit2 demo depends on space-ros:latest.  This
may prevent the image from building if we release a new version of Space ROS
but we have not yet adapted the MoveIt 2 demo as needed, breaking the build.

This commit pins the version of the Move It 2 demo to the latest version of
Space ROS that we have tested it with (humble-2024.10.0).
ivanperez-keera added a commit that referenced this issue Jan 31, 2025
The current dockerfile of the navigation2 demo depends on space-ros:latest.
This may prevent the image from building if we release a new version of Space
ROS but we have not yet adapted the Navigation 2 demo as needed, breaking the
build.

This commit pins the version of the Navigation 2 demo to the latest version of
Space ROS that we have tested it with (humble-2024.10.0).
ivanperez-keera added a commit that referenced this issue Jan 31, 2025
The current dockerfile of the moveit2 demo depends on space-ros:latest.  This
may prevent the image from building if we release a new version of Space ROS
but we have not yet adapted the MoveIt 2 demo as needed, breaking the build.

This commit pins the version of the Move It 2 demo to the latest version of
Space ROS that we have tested it with (humble-2024.10.0).
ivanperez-keera added a commit that referenced this issue Jan 31, 2025
The current dockerfile of the navigation2 demo depends on space-ros:latest.
This may prevent the image from building if we release a new version of Space
ROS but we have not yet adapted the Navigation 2 demo as needed, breaking the
build.

This commit pins the version of the Navigation 2 demo to the latest version of
Space ROS that we have tested it with (humble-2024.10.0).
ivanperez-keera added a commit that referenced this issue Jan 31, 2025
The current dockerfile of the moveit2 demo depends on space-ros:latest.  This
may prevent the image from building if we release a new version of Space ROS
but we have not yet adapted the MoveIt 2 demo as needed, breaking the build.

This commit pins the version of the MoveIt 2 demo to the latest version of
Space ROS that we have tested it with (humble-2024.10.0).
ivanperez-keera added a commit that referenced this issue Jan 31, 2025
The current dockerfile of the navigation2 demo depends on space-ros:latest.
This may prevent the image from building if we release a new version of Space
ROS but we have not yet adapted the Navigation 2 demo as needed, breaking the
build.

This commit pins the version of the Navigation 2 demo to the latest version of
Space ROS that we have tested it with (humble-2024.10.0).
@Bckempa Bckempa linked a pull request Jan 31, 2025 that will close this issue
ivanperez-keera added a commit that referenced this issue Jan 31, 2025
The current dockerfile of the moveit2 demo depends on space-ros:latest.  This
may prevent the image from building if we release a new version of Space ROS
but we have not yet adapted the MoveIt 2 demo as needed, breaking the build.

This commit pins the version of the MoveIt 2 demo to the latest version of
Space ROS that we have tested it with (humble-2024.10.0). We modify both the
Dockerfile and the build script so that the result is the same (and thus
unsurprising) no matter how the image is built.
ivanperez-keera added a commit that referenced this issue Jan 31, 2025
The current dockerfile of the navigation2 demo depends on space-ros:latest.
This may prevent the image from building if we release a new version of Space
ROS but we have not yet adapted the Navigation 2 demo as needed, breaking the
build.

This commit pins the version of the Navigation 2 demo to the latest version of
Space ROS that we have tested it with (humble-2024.10.0). We modify both the
Dockerfile and the build script so that the result is the same (and thus
unsurprising) no matter how the image is built.
Bckempa added a commit that referenced this issue Feb 1, 2025
Pin demos to humble-2024.10.0 release (#197)
@github-project-automation github-project-automation bot moved this from In Progress to Done in Space ROS Project Development Feb 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants