Make excluded pkgs consistent across rosdep and vcs (#88). #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xfiderek
force-pushed
the
docker/issue/88
branch
from
4f8c240 to
1042743
Compare
xfiderek
force-pushed
the
docker/issue/88
branch
from
1042743 to
205a16d
Compare
|
As discussed in space-ros/space-ros#126 (comment), we will hard-code ikos in --skip-keys for now |
Now 'excluded-pkgs.txt' can be used both to create list of repos (vcs), as well as to install necessary system dependencies (rosdep).
According to discussion space-ros/space-ros#126 (comment)
ivanperez-keera
force-pushed
the
docker/issue/88
branch
from
4efb9bf to
58a140a
Compare
Bckempa
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses #88.
Now 'excluded-pkgs.txt' can be used both to create list of repos (vcs), as well as to install necessary system dependencies (rosdep).
Dependencies
ament/ament_ikos#3space-ros/space-ros#131
Final test will be conducted after these PRs are merged, but any preliminary reviews are welcomed :).
Tests
I tested output of both versions with
rosdep install --simulateand there is 100% match.Open points
Prior to fix there was a
console_bridgepackage inskip-keys. There is no such package in rosdep index, so it had no effect. However I saw thatlibconsole-bridge-devgets installed, which is exactly the package that was intended to be excluded. Do we know what was the intention behind excluding this package?