Don't run vcs inside buildkit (#60) #96
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EzraBrooks
force-pushed
the
dont-run-vcstool-inside-containers
branch
2 times, most recently
from
1106f07 to
5d16021
Compare
EzraBrooks
force-pushed
the
dont-run-vcstool-inside-containers
branch
from
5d16021 to
a714f03
Compare
|
oy.. this might be somewhat blocked by #66 |
|
This change will be obviated by the larger refactor incoming |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #60.
There's some more changes to be made here, but I'm working on getting rid of the bad juju of doing SCM checkouts inside Dockerfiles.