Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Simplify separated screen top menu (#33047)" (Stable -> Master) #33785

Merged
merged 1 commit into from
Dec 8, 2024

Conversation

VasilisThePikachu
Copy link
Member

About the PR

This reverts commit f27fa1e.

Why / Balance

In the maintainer meeting, we concluded that we should talk more about this pr and which one of the two we should take before publishing. We have not seem to come to a conclusion. And as it stands this pr sadly cant come into stable with how it currently is.

I reverted and pushed into the stable branch and this is the upstream merge.

@Errant-4 has approved this and so have i

Requirements

@github-actions github-actions bot added size/S Denotes a PR that changes 10-99 lines. S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Dec 8, 2024
@VasilisThePikachu VasilisThePikachu changed the title Revert "Simplify separated screen top menu (#33047)" Revert "Simplify separated screen top menu (#33047)" (Stable -> Master) Dec 8, 2024
@github-actions github-actions bot added Changes: UI Changes: Might require knowledge of UI design or code. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. labels Dec 8, 2024
Copy link
Member

@Errant-4 Errant-4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with the revert, we can sort this out after we published
(waiting for the tests, just in case)

@Errant-4 Errant-4 merged commit 0c4dd9d into master Dec 8, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: No C# Changes: Requires no C# knowledge to review or fix this item. Changes: UI Changes: Might require knowledge of UI design or code. S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. size/S Denotes a PR that changes 10-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants