Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Purges use of EC TransformComponent.LocalRotation.set #34936

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Purges use of EC TransformComponent.LocalRotation.set #34936

wants to merge 7 commits into from

Conversation

TemporalOroboros
Copy link
Contributor

@TemporalOroboros TemporalOroboros commented Feb 7, 2025 •
edited
Loading

About the PR

I switched all uses of TransformComponent.LocalRotation.set in content over to SharedTransformSystem.SetLocalRotationNoLerp
Also switched over the remaining setters for TransformComponent.NoLocalRotation
Requires space-wizards/RobustToolbox#5663

Why / Balance

Part of the slow effort to ECS TransformComponent

Requirements

Breaking changes

ReplaySpectatorSystem.SpawnSpectatorGhost now returns an Entity<TransformComponent> instead of a raw TransformComponent. (Done to prevent adding an IComponent.Owner access when setting the rotations.)

@github-actions github-actions bot added S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. S: Needs Review Status: Requires additional reviews before being fully accepted size/M Denotes a PR that changes 100-999 lines. labels Feb 7, 2025
@ArtisticRoomba ArtisticRoomba added P3: Standard Priority: Default priority for repository items. T: Cleanup Type: Code clean-up, without being a full refactor or feature D2: Medium Difficulty: A good amount of codebase knowledge required. A: Core Tech Area: Underlying core tech for the game and the Github repository. S: Needs Engine PR Merged Status: Requires an existing Robust Toolbox PR to be merged first. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Feb 8, 2025
@TemporalOroboros TemporalOroboros force-pushed the ECS-TransformComponent-LocalRotation branch from 1e8d586 to 00f155e Compare February 10, 2025 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@metalgearsloth metalgearsloth Awaiting requested review from metalgearsloth metalgearsloth is a code owner

@Partmedia Partmedia Awaiting requested review from Partmedia Partmedia is a code owner

Assignees
No one assigned
Labels
A: Core Tech Area: Underlying core tech for the game and the Github repository. D2: Medium Difficulty: A good amount of codebase knowledge required. P3: Standard Priority: Default priority for repository items. S: Needs Engine PR Merged Status: Requires an existing Robust Toolbox PR to be merged first. S: Needs Review Status: Requires additional reviews before being fully accepted size/M Denotes a PR that changes 100-999 lines. T: Cleanup Type: Code clean-up, without being a full refactor or feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TemporalOroboros @ArtisticRoomba