Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Purges the one remaining use of TransformComponent.WorldPosition in content. #34943

Merged
merged 2 commits into from
Feb 10, 2025
Merged

Purges the one remaining use of TransformComponent.WorldPosition in content. #34943

merged 2 commits into from
Feb 10, 2025

Conversation

TemporalOroboros
Copy link
Contributor

About the PR

See title.

Why / Balance

ECSing TransformComponent

Technical details

TransformComponent.WorldPosition -> SharedTransformSystem.GetWorldPosition

Requirements

@github-actions github-actions bot added S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. size/XS Denotes a PR that changes 0-9 lines. labels Feb 7, 2025
@ArtisticRoomba ArtisticRoomba added P3: Standard Priority: Default priority for repository items. T: Cleanup Type: Code clean-up, without being a full refactor or feature D2: Medium Difficulty: A good amount of codebase knowledge required. S: Needs Review Status: Requires additional reviews before being fully accepted A: Core Tech Area: Underlying core tech for the game and the Github repository. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Feb 8, 2025
@metalgearsloth metalgearsloth merged commit 3b3c286 into space-wizards:master Feb 10, 2025
12 checks passed
@metalgearsloth metalgearsloth mentioned this pull request Feb 10, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A: Core Tech Area: Underlying core tech for the game and the Github repository. D2: Medium Difficulty: A good amount of codebase knowledge required. P3: Standard Priority: Default priority for repository items. S: Needs Review Status: Requires additional reviews before being fully accepted size/XS Denotes a PR that changes 0-9 lines. T: Cleanup Type: Code clean-up, without being a full refactor or feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TemporalOroboros @metalgearsloth @ArtisticRoomba