Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Purges final uses of TransformComponent.InvLocalMatrix #34947

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Purges final uses of TransformComponent.InvLocalMatrix #34947

wants to merge 1 commit into from

Conversation

TemporalOroboros
Copy link
Contributor

Changes the last extant uses of TransformComponent.LocalMatrix to instead use SharedTransformSystem.GetInvLocalMatrix

About the PR

Removes the last extant references to TransformComponent.InvLocalMatrix outside of the engine.
Requires space-wizards/RobustToolbox#5663

Why / Balance

ECS TransformComponent

Technical details

TransformComponent.InvLocalMatrix -> SharedTransformSystem.GetLocalMatrix

Requirements

@github-actions github-actions bot added S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. size/XS Denotes a PR that changes 0-9 lines. labels Feb 7, 2025
@ArtisticRoomba ArtisticRoomba added P3: Standard Priority: Default priority for repository items. S: Needs Engine PR Merged Status: Requires an existing Robust Toolbox PR to be merged first. T: Cleanup Type: Code clean-up, without being a full refactor or feature D2: Medium Difficulty: A good amount of codebase knowledge required. S: Needs Review Status: Requires additional reviews before being fully accepted A: Core Tech Area: Underlying core tech for the game and the Github repository. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Feb 8, 2025
@TemporalOroboros
Resolves uses of .InvLocalMatrix
5086c4f 
Switches uses of TransformComponent.InvLocalMatrix to use SharedTransformSystem.GetInvLocalMatrix
@TemporalOroboros TemporalOroboros force-pushed the ECS-TransformComponent-LocalMatrices branch from 0b2a766 to 5086c4f Compare February 10, 2025 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A: Core Tech Area: Underlying core tech for the game and the Github repository. D2: Medium Difficulty: A good amount of codebase knowledge required. P3: Standard Priority: Default priority for repository items. S: Needs Engine PR Merged Status: Requires an existing Robust Toolbox PR to be merged first. S: Needs Review Status: Requires additional reviews before being fully accepted size/XS Denotes a PR that changes 0-9 lines. T: Cleanup Type: Code clean-up, without being a full refactor or feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TemporalOroboros @ArtisticRoomba