Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add chatty lathes #34959

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add chatty lathes #34959

wants to merge 1 commit into from

Conversation

sowelipililimute
Copy link
Contributor

About the PR

Lathes now have a LatheChattyComponent that can be added to cause them to communicate when they gain new recipes from a research server, i.e. emagged recipes aren't announced.

Why / Balance

This is mostly a PR that I intend to facilitate departamental lathes in downstream servers to avoid needing to patch existing code in the research system that would be prone to merge conflicts if something was changed upstream later on.
However, I think this is a nice-to-have for the two departamental lathes that exist upstream, so I am submitting it with that content change.

Technical details

  • LatheChattyComponent exists
  • LatheSystem now listens to (LatheChattyComponent, TechnologyDatabaseModifiedEvent) and broadcasts on the provided radio channels
  • TechnologyDatabaseModifiedEvent now has a field for carrying which recipes were unlocked by the research

Media

grafik

Requirements

🆑

  • add: The medical and security techfabs now announce new recipes that they can fabricate as they are researched

Changelog

@github-actions github-actions bot added S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. size/S Denotes a PR that changes 10-99 lines. labels Feb 7, 2025
@walksanatora
Copy link

so this is similar to goobstation where when a lathe gets a new recipe it will say above it "new recipies recieved" or something.

@sowelipililimute sowelipililimute force-pushed the work/jblackquill/chatty-lathes branch from 269ef8f to 0d3bb8f Compare February 7, 2025 22:44
lzk228
lzk228 reviewed Feb 8, 2025
View reviewed changes
Copy link
Contributor

@lzk228 lzk228 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only one little thing, and i don't know about the name "LatheChatty"
otherwise lgtm

@lzk228 lzk228 added P3: Standard Priority: Default priority for repository items. T: New Feature Type: New feature or content, or extending existing content D3: Low Difficulty: Some codebase knowledge required. S: Needs Review Status: Requires additional reviews before being fully accepted A: General Interactions Area: General in-game interactions that don't relate to another area. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Feb 8, 2025
@sowelipililimute sowelipililimute force-pushed the work/jblackquill/chatty-lathes branch 4 times, most recently from d843dea to 84e4aa5 Compare February 8, 2025 18:26
beck-thompson
beck-thompson approved these changes Feb 8, 2025
View reviewed changes
Copy link
Contributor

@beck-thompson beck-thompson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works good! This makes a lot of sense 👍

@beck-thompson beck-thompson added the S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. label Feb 8, 2025
@sowelipililimute sowelipililimute force-pushed the work/jblackquill/chatty-lathes branch from 84e4aa5 to bb51c49 Compare February 8, 2025 18:33
@notquitehadouken
Copy link
Contributor

what if there's more than one lathe

@github-actions github-actions bot added the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Feb 15, 2025
@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@sowelipililimute sowelipililimute force-pushed the work/jblackquill/chatty-lathes branch from bb51c49 to 7e3652c Compare February 17, 2025 16:08
@github-actions github-actions bot removed the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lzk228 lzk228 lzk228 left review comments

@beck-thompson beck-thompson beck-thompson approved these changes

Assignees
No one assigned
Labels
A: General Interactions Area: General in-game interactions that don't relate to another area. D3: Low Difficulty: Some codebase knowledge required. P3: Standard Priority: Default priority for repository items. S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. S: Needs Review Status: Requires additional reviews before being fully accepted size/S Denotes a PR that changes 10-99 lines. T: New Feature Type: New feature or content, or extending existing content
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sowelipililimute @walksanatora @notquitehadouken @beck-thompson @lzk228