-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing ContrabandSystem to check for Syndicate and Centcomm explicitly #35098
base: master
Are you sure you want to change the base?
Conversation
# Conflicts: # Content.Shared/Contraband/ContrabandSystem.cs
Should be fixed and cleaned up. I don't know if the hardcoded "CentralCommand" is the best way for this, or maybe making a group of high command that if you have that ID, you overwrite any contraband. For Wizden, I don't see this being necessarily the case, but may be an option in the future for a downstream if they have that sort of thing. |
Yeah, even though it works I'm not sure if this should be the solution here, as this is hardcoded. Iffy for forks and if we ever want to change this ourselves down the line. |
I think a good way to do this is. Severity: Minor, Moderate, High; seperate syndicate severity off this and make it its own job. Make allowed departments have Syndicate which by default is not allowed, and any items that inherits that depsrtment comes up as the syndicate text. This would make items like the Ninja gear not major, but high (maybe even extreme). I am tempted to classify all ninja equipment as syndicate as the syndicate as a term in my opinion is a label that NT places on opposing companies or people. Basically a label they have ingrained into their workers to tell them who is bad. Forks can then make seperate listings for departments. We can make a positive override (if you are that job, you are allowed everything) and a negative one (if your item is allowed in that job, but is against NT/station, it is always disallowed). |
About the PR
Syndicate items that inherit from other items that have contraband components seem to allow departments from that previously inherited item to "be able to carry the item". This now blanket bans all syndicate items to never be allowed to be on the station.
This also changes it so anyone who is centcomm is fully allowed to use all items, being that centcomm is a rare thing and they make all da rules
Why / Balance
Only a few items had this bug, this just fixes it and gives centcomm more power for those who may use them down stream.
Technical details
Edited ContrabandSystem to check if the severity is syndicate, and if so would always make the check fail to show the dis-allow string.
Added a seperate check that skips all others that if you are CentralCommand, always allow.
Media
Requirements
Breaking changes
Those downstream who may rename CentralCommand may have this break.
Changelog
🆑