Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

light brown fibers #35111

Merged
merged 1 commit into from
Feb 12, 2025
Merged

light brown fibers #35111

merged 1 commit into from
Feb 12, 2025

Conversation

Ghagliiarghii
Copy link
Contributor

@Ghagliiarghii Ghagliiarghii commented Feb 12, 2025 •
edited
Loading

About this PR

Added light brown fibers to locale, changed the fiber type for light brown gloves and light brown towel (I'm personally unsure how to leave fibers with a towel but it previously had the brown fiber type)

Why / Balance

I personally thought it was slightly odd that it was impossible to visually distinguish between light brown and dark brown fibers. This was brought to my attention by a recent Liltenhead video.

Technical details

See about this PR section, very minor change.

Media

image

Requirements

Breaking changes

No breaking changes

Changelog

🆑 Xillan

  • tweak: Changed light brown gloves to have their own unique fiber for detectives, where previously they were indistinguishable from normal / dark brown gloves.

@github-actions github-actions bot added S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. size/XS Denotes a PR that changes 0-9 lines. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. size/XS Denotes a PR that changes 0-9 lines. labels Feb 12, 2025
@themias
Copy link
Contributor

themias commented Feb 12, 2025

I think this could be worth a CL, since detectives/antags might want to be aware of this.

@beck-thompson
Copy link
Contributor

classic liltenhead video pr

beck-thompson
beck-thompson approved these changes Feb 12, 2025
View reviewed changes
Copy link
Contributor

@beck-thompson beck-thompson left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Edit: Yeah adding a CL is probably a good idea

@beck-thompson beck-thompson added the S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. label Feb 12, 2025
@Pumkin69
Copy link

free contributor role :godo:

@lzk228
Copy link
Contributor

lzk228 commented Feb 12, 2025

classic liltenhead video pr

i am waiting mailing units update :trollface:

@Ghagliiarghii
Copy link
Contributor Author

free contributor role :godo:

I've already done a couple

classic liltenhead video pr

So true bestie

I think this could be worth a CL, since detectives/antags might want to be aware of this.

Will add

@Tayrtahn Tayrtahn merged commit 859918f into space-wizards:master Feb 12, 2025
14 checks passed
@Ghagliiarghii Ghagliiarghii deleted the light-brown-fibers branch February 12, 2025 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tayrtahn Tayrtahn Tayrtahn approved these changes

@beck-thompson beck-thompson beck-thompson approved these changes

Assignees
No one assigned
Labels
Changes: No C# Changes: Requires no C# knowledge to review or fix this item. S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Ghagliiarghii @themias @beck-thompson @Pumkin69 @lzk228 @Tayrtahn